Implement search functionality in more areas of the app

[codenyte]

Is Your Feature Request Related to a Problem?

No response

Feature Description

There are some areas of the app that could really benefit from a search feature. Examples of this are:

• Comments
  Before I switched from iOS to Android and from Reddit to Lemmy, I used to use the Apollo client for Reddit. I really miss the search feature in the comment section. Just realized that this feature exists, it's just hidden away. Could be improved though.
  • Comment search box at the top of the post page
    Similar to what Apollo did. I don't have any screenshots, so I had to look for one on the web. This is the best I could find, yes I know it's pretty blurry unfortunately, but I think it's still possible to get the general concept from this.
    
• User posts/comments
  Lemmy's official feature even supports this
• Saved posts
  I also remember this feature from Apollo and I found it to be really useful
• (Inbox)
  Maybe there could also a search box for the Inbox? This isn't really necessary, but there are some situations in which it might be useful. This one is not as important though.

Alternative Solutions

N/A

Additional Context

I wasn't sure whether to combine these into one issue or to open seperate issues for the search functionality in the individual areas of the app

[micahmo]

Hey @codenyte, thanks for the issue! I think it's ok to have all of these in one. Maybe we can make them into checkboxes in your original post so we can check them off as they're done.

• search feature in the comment section

I believe this was implemented in #887! Take a look at the video (or try yourself) and let me know if that's what you had in mind!

[codenyte]

Damn, I did not realize that this feature exists. It's kinda hidden away, maybe add an option to display a search box at the top of the comment page, similar to Apollo? Is this worth considering?

Edit: It's even more confusing, because I don't see the three dots as can be seen in your screen recording, but instead, I see a reply button. The search button is only revealed when long pressing on the reply button. I find this to be pretty confusing, I don't think I would have ever found this myself.

[micahmo]

maybe add an option to display a search box at the top of the comment page, similar to Apollo? Is this worth considering?

Sure, we can definitely try to make it more visible! Do you think it would be visible enough if it were in the overflow menu (three dots) at the top?

I don't see the three dots as can be seen in your screen recording, but instead, I see a reply button. The search button is only revealed when long pressing on the reply button.

Ahh, that's due to the FAB settings. I believe the default is to reply on single press and show the additional options on long press or swipe up. I have mine set to show additional options on single press (hence the three dots). It provides more visibility, but it also removes the ability to perform a single action without multiple taps. The nice thing is that the FAB is super customizable. You can even have separate actions for short and long press, and still access all the additional items with a swipe. Try messing around with these settings! 😊

[codenyte]

Thanks a lot! I now have the Floating Action Button set to work as a search button. For some reason, it doesn't work though. It appears to be a bug? I tap on the FAB (which now has a search icon) and nothing happens. I can only bring up the search by swiping up from the FAB and selecting Search from the menu. Will add a screen recording later.

[micahmo]

Wow, nice catch! No need for a video as I can reproduce. Thanks!

[micahmo]

Comment search box at the top of the post page

Thanks for the additional suggestion! Are you thinking the search box would be at the top of the screen always (until the user scrolls) or only when a certain action is performed (like pressing a search button somewhere)?

[codenyte]

I would avoid a search button. Maybe an option in the settings to always show it by default, and otherwise the user can bring it up by scrolling up when at the top of the post page. I imagine it something like this: Scroll up to the top of the post page, scroll a little further up to reveal the search box, scroll even further to reload the page. I'm gonna have to sideload Apollo on my iPhone with a custom Reddit API key to check out how they were doing it, because I remember Apollo having a very good solution for this with great UI/UX.

[micahmo]

Scroll up to the top of the post page, scroll a little further up to reveal the search box, scroll even further to reload the page.

FWIW, this is a very iOS technique that would confuse a lot of Android users. Personally I've always found it counterintuitive that iOS hides search bars behind a gesture that otherwise gives no indication that it will reveal a search bar. I spent forever looking around iMessage for a search feature until I discovered this gesture. 😆 But that's just my 2 cents, and I know iOS users probably find it intuitive by now. 😊

[codenyte]

Ok sure, I haven't thought about that, as this just feels natural to me because I used iOS for many years. We can go for a simpler approach then. A simple toggle in the settings that enables the search box. I would enable it by default, while still allowing users who don't like it to disable it from the settings. Otherwise the search feature can still be used from the FAB (either if it's configured to show it directly, or by swiping up)

[hjiangsu]

Just giving my opinion on this discussion - I think we can add in the search option as part of the overflow menu (three dots) as @micahmo mentioned, and have the option to show a search box as @codenyte suggested! This should cover the issue of discoverability for the search feature.

Generally speaking, I don't mind having different methods to access the same feature if it helps with discoverability 😄.

[codenyte]

If possible, maybe implement the search option in the overflow menu in a way that it's only shown when the search box is disabled. I think that would make the most sense.