Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test throws error #337

Closed
ariymarkowitz opened this issue Feb 4, 2023 · 3 comments
Closed

Test throws error #337

ariymarkowitz opened this issue Feb 4, 2023 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ariymarkowitz
Copy link

ariymarkowitz commented Feb 4, 2023

When I run yarn test (without having made any changes to the code), I get the following:

The 'whitespace' rule threw an error in '/Users/arimarkowitz/three-ts-types/types/three/src/Three.d.ts':
TypeError: Cannot read properties of undefined (reading 'forEach')
    at cb (/Users/arimarkowitz/three-ts-types/node_modules/tslint/lib/rules/whitespaceRule.js:140:45)
    at visitNodes (/Users/arimarkowitz/three-ts-types/node_modules/typescript/lib/typescript.js:31214:30)
    at forEachChildInSourceFile (/Users/arimarkowitz/three-ts-types/node_modules/typescript/lib/typescript.js:31573:20)
    at Object.forEachChild (/Users/arimarkowitz/three-ts-types/node_modules/typescript/lib/typescript.js:31988:47)
    at walk (/Users/arimarkowitz/three-ts-types/node_modules/tslint/lib/rules/whitespaceRule.js:99:8)
    at Rule.AbstractRule.applyWithFunction (/Users/arimarkowitz/three-ts-types/node_modules/tslint/lib/language/rule/abstractRule.js:39:9)
    at Rule.apply (/Users/arimarkowitz/three-ts-types/node_modules/tslint/lib/rules/whitespaceRule.js:41:21)
    at Linter.applyRule (/Users/arimarkowitz/three-ts-types/node_modules/tslint/lib/linter.js:214:29)
    at /Users/arimarkowitz/three-ts-types/node_modules/tslint/lib/linter.js:155:85
    at Object.flatMap (/Users/arimarkowitz/three-ts-types/node_modules/tslint/lib/utils.js:160:29)
@ariymarkowitz ariymarkowitz added the bug Something isn't working label Feb 4, 2023
@Methuselah96
Copy link
Contributor

Thanks for creating an issue, this has been happening for a while (it doesn't cause the command to fail). Would love it if someone could look into it.

@Methuselah96 Methuselah96 added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 5, 2023
@Methuselah96
Copy link
Contributor

Methuselah96 commented Feb 7, 2023

Looks like this a bug in dtslint (see microsoft/dtslint#322) and presumably would need to be fixed in https://github.com/microsoft/DefinitelyTyped-tools since the original dtslint repo is archived.

@Methuselah96 Methuselah96 removed the good first issue Good for newcomers label Feb 7, 2023
@Methuselah96
Copy link
Contributor

I think this no longer occurs (probably due to DT switching completely to eslint).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants