Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.132.1 serves type definition of r133 by mistake? #136

Closed
0b5vr opened this issue Oct 1, 2021 · 5 comments
Closed

0.132.1 serves type definition of r133 by mistake? #136

0b5vr opened this issue Oct 1, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@0b5vr
Copy link
Contributor

0b5vr commented Oct 1, 2021

  • three version: Boundary between r132 / r133
  • node version: ----
  • npm (or yarn) version: ----

Problem description:

@types/three#0.132.1 .
I just noticed that the type signature of GLTFReference in GLTFLoader.d.ts has been changed to r133 's one by mistake.

You might possibly have been used dev instead of master when you publish 0.132.1 ...?

Relevant code:

GLTFLoader.d.ts @ @types/three#0.132.0:
https://unpkg.com/browse/@types/[email protected]/examples/jsm/loaders/GLTFLoader.d.ts

GLTFLoader.d.ts @ @types/three#0.132.1:
https://unpkg.com/browse/@types/[email protected]/examples/jsm/loaders/GLTFLoader.d.ts

The PR introduces the change ( three ):
mrdoob/three.js#21737

@0b5vr 0b5vr added the bug Something isn't working label Oct 1, 2021
@0b5vr
Copy link
Contributor Author

0b5vr commented Oct 1, 2021

I can't find when you have changed this definition in this repository...? It might be your local change

@Methuselah96
Copy link
Contributor

Yeah, unfortunately sometimes some changes sneak in through DefinitelyTyped and are merged in by DT maintainers without waiting for our review. In this case DefinitelyTyped/DefinitelyTyped#55977 was the PR that snuck through.

@joshuaellis
Copy link
Member

I've left a comment addressing this issue. Thanks for raising it @0b5vr.

@0b5vr
Copy link
Contributor Author

0b5vr commented Oct 1, 2021

Ouchhh, I got the story. Thank you for addressing this, Close this issue once it is settled on DT side.

@joshuaellis
Copy link
Member

They've just reverted that PR, r132.1 will still be broken, but r132.2 will work I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants