Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bithumb: Add subscription configuration #1618

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Bithumb: Add subscription configuration

56a820f
Select commit
Loading
Failed to load commit list.
Open

Bithumb: Add subscription configuration #1618

Bithumb: Add subscription configuration
56a820f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 28, 2024 in 1s

36.36% (+0.00%) compared to 225429b

View this Pull Request on Codecov

36.36% (+0.00%) compared to 225429b

Details

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 36.36%. Comparing base (225429b) to head (56a820f).
Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
exchanges/bithumb/bithumb_websocket.go 86.95% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1618   +/-   ##
=======================================
  Coverage   36.36%   36.36%           
=======================================
  Files         422      422           
  Lines      183105   183099    -6     
=======================================
+ Hits        66588    66589    +1     
+ Misses     108475   108472    -3     
+ Partials     8042     8038    -4     
Files with missing lines Coverage Δ
exchanges/bithumb/bithumb_wrapper.go 29.78% <100.00%> (+0.10%) ⬆️
exchanges/subscription/subscription.go 100.00% <ø> (ø)
exchanges/bithumb/bithumb_websocket.go 50.33% <86.95%> (+6.02%) ⬆️

... and 18 files with indirect coverage changes