Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huobi: Add Subscription configuration #1604

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

gbjk
Copy link
Collaborator

@gbjk gbjk commented Aug 6, 2024

Just adds configurable subs.

This PR does not fix auth WS usage, which appears broken due to using deprecated v1 paths.
Also doesn't seek to make subs synchronous.

Stacked Dependencies

Type of change

  • New feature (non-breaking change which adds functionality)

@gbjk gbjk added the nomerge requires dependency This pull request is dependent on another, so it can't be merged until the dependent one is merged label Aug 6, 2024
@gbjk gbjk self-assigned this Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 36.52%. Comparing base (b602d54) to head (554f69c).
Report is 29 commits behind head on master.

Files with missing lines Patch % Lines
exchanges/huobi/huobi_websocket.go 37.14% 22 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1604      +/-   ##
==========================================
- Coverage   38.22%   36.52%   -1.70%     
==========================================
  Files         422      414       -8     
  Lines      152222   179325   +27103     
==========================================
+ Hits        58184    65503    +7319     
- Misses      85984   105951   +19967     
+ Partials     8054     7871     -183     
Files with missing lines Coverage Δ
exchanges/huobi/huobi_wrapper.go 39.89% <100.00%> (-2.59%) ⬇️
exchanges/subscription/list.go 100.00% <100.00%> (ø)
exchanges/subscription/subscription.go 100.00% <ø> (ø)
exchanges/huobi/huobi_websocket.go 29.87% <37.14%> (+1.24%) ⬆️

... and 396 files with indirect coverage changes

@gbjk gbjk added review me This pull request is ready for review and removed nomerge requires dependency This pull request is dependent on another, so it can't be merged until the dependent one is merged labels Aug 13, 2024
@gbjk gbjk requested review from shazbert, gloriousCode and thrasher- and removed request for shazbert and gloriousCode August 13, 2024 09:13
Copy link
Collaborator

@shazbert shazbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, minor potential nit

exchanges/huobi/huobi_websocket.go Outdated Show resolved Hide resolved
@gbjk gbjk requested a review from shazbert August 28, 2024 03:55
Copy link
Collaborator

@shazbert shazbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rebase/merge of master required review me This pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants