-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Huobi: Add Subscription configuration #1604
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1604 +/- ##
==========================================
- Coverage 38.22% 36.52% -1.70%
==========================================
Files 422 414 -8
Lines 152222 179325 +27103
==========================================
+ Hits 58184 65503 +7319
- Misses 85984 105951 +19967
+ Partials 8054 7871 -183
|
70dc2b1
to
b4f8fa0
Compare
b4f8fa0
to
315c634
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff, minor potential nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Just adds configurable subs.
This PR does not fix auth WS usage, which appears broken due to using deprecated v1 paths.
Also doesn't seek to make subs synchronous.
Stacked Dependencies
Type of change