Subscriptions: Fix subscription.Clone Params and Pairs #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gloriousCode
requested changes
Jul 17, 2024
5 tasks
thrasher-
approved these changes
Jul 19, 2024
gbjk
added a commit
to gbjk/gocryptotrader
that referenced
this pull request
Aug 9, 2024
…#1582) * Subscriptions: Fix subscription.Clone Params and Pairs * fixup! Subscriptions: Fix subscription.Clone Params and Pairs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Clone() affecting the original and not the clone for Pairs and Params.
That actually meant it would pass tests, and kinda work, but not in the way expected, and definitely not thread safe on the original parent
Type of change