Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kucoin: Add subscription templating and various fixes #1579

Merged
merged 18 commits into from
Aug 9, 2024

Commits on Jul 27, 2024

  1. Currency: Variadic Pairs.Add

    This version of Pairs.Add is simpler and [more
    performant](https://gist.github.com/gbjk/06a1fc1832d04ee41213ca518938cf74)
    
    Behavioural difference: If there's nothing to add, the same slice is
    returned unaltered. This seems like good sauce
    gbjk committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    4224fd8 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Currency: Variadic Remove

    gbjk committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    74dd14b View commit details
    Browse the repository at this point in the history
  2. Common: Add Batch function

    gbjk committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    e0c9cbc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2d2943e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5e5dfdb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    eba05a5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9b03a5a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9826a78 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9fcf2dd View commit details
    Browse the repository at this point in the history
  9. Subscriptions: Filter AssetPairs

    Now only the assetPairs relevant to the subscription are in the context
    gbjk committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    f7b4a88 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    26659ad View commit details
    Browse the repository at this point in the history
  11. Subscriptions: Trim AssetSeparator early

    We want to trim before checking for "AssetSeparator vs All" because a
    template should be allowed to reuse a range template and generate just one trailing AssetSeparator
    whilst using a specific Asset
    gbjk committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    78da9e2 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    554cadb View commit details
    Browse the repository at this point in the history
  13. Kucoin: Add Subscription batching

    Turns out that contary to the documentation, kucoin supports batching of
    all symbols and currencies
    gbjk committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    a6bc3df View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    b6d52a9 View commit details
    Browse the repository at this point in the history
  15. Subscriptions: Simplify error checking

    This reduces the complexity of error checking to just be "do we get the
    correct numbers".
    
    Fixes Asset.All with only one asset erroring on xpandPairs, because we
    trimmed the only asset separator, and then errored that we're not
    xpanding Assets and the asset on the sub is asset.All
    
    This use-case conflicted with commit 6bbd546, which required:
    ```
    Subscriptions: Trim AssetSeparator early
    
    We want to trim before checking for "AssetSeparator vs All" because a
    template should be allowed to reuse a range template and generate just one trailing AssetSeparator
    whilst using a specific Asset
    ```
    
    Now we set up the assets earlier, and we remove the check for xpandAssets, since the number of asset lines matching is all that matters.
    
    I've removed the asset tests for this, but they were correctly erroring
    on the number of asset lines instead.
    
    Everything hits coverage, as well.
    gbjk committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    96b177e View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    82c5a54 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. BTCMarkets: Use common.Batch

    gbjk committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    7c3d7fb View commit details
    Browse the repository at this point in the history