-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kucoin: Add subscription templating and various fixes #1579
Merged
thrasher-
merged 18 commits into
thrasher-corp:master
from
gbjk:feature/kucoin_sub_templating
Aug 9, 2024
Merged
Kucoin: Add subscription templating and various fixes #1579
thrasher-
merged 18 commits into
thrasher-corp:master
from
gbjk:feature/kucoin_sub_templating
Aug 9, 2024
Commits on Jul 27, 2024
-
This version of Pairs.Add is simpler and [more performant](https://gist.github.com/gbjk/06a1fc1832d04ee41213ca518938cf74) Behavioural difference: If there's nothing to add, the same slice is returned unaltered. This seems like good sauce
Configuration menu - View commit details
-
Copy full SHA for 4224fd8 - Browse repository at this point
Copy the full SHA 4224fd8View commit details
Commits on Aug 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 74dd14b - Browse repository at this point
Copy the full SHA 74dd14bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e0c9cbc - Browse repository at this point
Copy the full SHA e0c9cbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d2943e - Browse repository at this point
Copy the full SHA 2d2943eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e5dfdb - Browse repository at this point
Copy the full SHA 5e5dfdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for eba05a5 - Browse repository at this point
Copy the full SHA eba05a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b03a5a - Browse repository at this point
Copy the full SHA 9b03a5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9826a78 - Browse repository at this point
Copy the full SHA 9826a78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fcf2dd - Browse repository at this point
Copy the full SHA 9fcf2ddView commit details -
Subscriptions: Filter AssetPairs
Now only the assetPairs relevant to the subscription are in the context
Configuration menu - View commit details
-
Copy full SHA for f7b4a88 - Browse repository at this point
Copy the full SHA f7b4a88View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26659ad - Browse repository at this point
Copy the full SHA 26659adView commit details -
Subscriptions: Trim AssetSeparator early
We want to trim before checking for "AssetSeparator vs All" because a template should be allowed to reuse a range template and generate just one trailing AssetSeparator whilst using a specific Asset
Configuration menu - View commit details
-
Copy full SHA for 78da9e2 - Browse repository at this point
Copy the full SHA 78da9e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 554cadb - Browse repository at this point
Copy the full SHA 554cadbView commit details -
Kucoin: Add Subscription batching
Turns out that contary to the documentation, kucoin supports batching of all symbols and currencies
Configuration menu - View commit details
-
Copy full SHA for a6bc3df - Browse repository at this point
Copy the full SHA a6bc3dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for b6d52a9 - Browse repository at this point
Copy the full SHA b6d52a9View commit details -
Subscriptions: Simplify error checking
This reduces the complexity of error checking to just be "do we get the correct numbers". Fixes Asset.All with only one asset erroring on xpandPairs, because we trimmed the only asset separator, and then errored that we're not xpanding Assets and the asset on the sub is asset.All This use-case conflicted with commit 6bbd546, which required: ``` Subscriptions: Trim AssetSeparator early We want to trim before checking for "AssetSeparator vs All" because a template should be allowed to reuse a range template and generate just one trailing AssetSeparator whilst using a specific Asset ``` Now we set up the assets earlier, and we remove the check for xpandAssets, since the number of asset lines matching is all that matters. I've removed the asset tests for this, but they were correctly erroring on the number of asset lines instead. Everything hits coverage, as well.
Configuration menu - View commit details
-
Copy full SHA for 96b177e - Browse repository at this point
Copy the full SHA 96b177eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 82c5a54 - Browse repository at this point
Copy the full SHA 82c5a54View commit details
Commits on Aug 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7c3d7fb - Browse repository at this point
Copy the full SHA 7c3d7fbView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.