Cast all values before insert #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| |> cast_fields(struct) | ||
| end | ||
|
|
||
| defp cast_fields(fields, struct) do |
There was a problem hiding this comment.
Thoughts on naming this cast_all_fields or something like that? I didn't notice the s at the end and thought the next function was the same, but with different patterns. Changing the name might help to clarify that a bit
|
A few questions/comments. Overall this looks awesome. Can't wait to use this. Will be so handy with dates generated with GoodTimes! |
jsteiner
force-pushed
the
js-cast
branch
3 times, most recently
from
b3e8ad8
to
7801a86
Compare
Casts each field based on the type declared in the schema. Recursively casts built associations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Casts each field based on the type declared in the schema. Recursively casts built associations.
I added the ability to cast bare maps, but left it separate. After thinking on it some more, I'm not convinced it should be a feature of ExMachina. I couldn't think of a time when you would be building a record with ExMachina, but would want to pass an association in as a bare map. Curious if anybody else has some use cases for that.