Add params_with_assocs function #124
Conversation
| @@ -66,6 +70,33 @@ defmodule ExMachina.Ecto do | |||
| |> drop_ecto_fields | |||
| end | |||
|
|
|||
| @doc """ | |||
| Same as `params_for/2`, but it inserts all associations and sets the | |||
| foreign_keys. | |||
There was a problem hiding this comment.
I think that it should only insert the belongs_to associations and not has_many. What do you think?
Same asparams_for/2, but it inserts all belongs_to associations and sets the foreign keys
|
This is awesome! I was actually going to ask if you had time to tackle this next :D |
jsteiner
force-pushed
the
js-params-with-assocs
branch
3 times, most recently
from
ec71427
to
01dfce0
Compare
| @@ -66,6 +73,50 @@ defmodule ExMachina.Ecto do | |||
| |> drop_ecto_fields | |||
| end | |||
|
|
|||
| @doc """ | |||
| Same as `params_for/2`, but it inserts all belongs_to associations and sets the | |||
There was a problem hiding this comment.
Maybe this could be shortened to Same asparams_for/2, but inserts all belongs_to associations and sets the foreign keys? If you don't like that I'm fine with it as-is as well
|
A few comments, but this looks really good :) Good to merge whenever you're ready |
| @@ -43,14 +43,18 @@ defmodule ExMachina.EctoTest do | |||
| end | |||
| end | |||
|
|
|||
| test "params_with_assocs/2 inserts belongs_to associations" do | |||
| test "params_with_assocs/2 inserts belongs_tos that are set by the factory" do | |||
| assert Enum.member?(ExMachina.Article.__schema__(:associations), :editor) | |||
There was a problem hiding this comment.
I like this, but I think extracting to a private function would be good. Something like assert has_association_in_schema?(ExMachina.Article, :editor). What do you think?
jsteiner
force-pushed
the
js-params-with-assocs
branch
2 times, most recently
from
7377c3f
to
607d082
Compare
jsteiner
force-pushed
the
js-params-with-assocs
branch
from
607d082
to
84ccf51
Compare
Addresses: #105