Make bower an optional dependency
#532
Conversation
seanpdoyle
force-pushed
the
conditionally-invoke-bower
branch
from
ec396a2
to
5b1b514
Compare
|
Words seem right, code seems right. |
lib/ember_cli/path_set.rb
Outdated
| @@ -63,18 +67,19 @@ def build_error_file | |||
| def bower | |||
| @bower ||= begin | |||
| bower_path = app_options.fetch(:bower_path) { which("bower") } | |||
| bower_executable = Pathname(bower_path.to_s) | |||
There was a problem hiding this comment.
I was surprised this works! Is there any notable difference between Pathname.new and Pathname()?
There was a problem hiding this comment.
I don't remember exactly where I saw this syntax, but it came from docs.
It's definitely surprising, I'll replace it with Pathname.new.
There was a problem hiding this comment.
@geoffharcourt I plan to merge #533 ahead of this PR.
seanpdoyle
force-pushed
the
conditionally-invoke-bower
branch
2 times, most recently
from
b8d96af
to
02afd8f
Compare
Closes [#531]. According to `bower` warning messages, the project is semi-deprecated: ``` While Bower is maintained, we recommend Yarn and Webpack for *new* front-end projects! Yarn's advantage is security and reliability, and Webpack's is support for both CommonJS and AMD projects. Currently there's no migration path but we hope you'll help us figure out one. ``` As such, the build process will skip `bower install` and won't require a `bower` if the application's `bower.json` file is missing. [#531]: #531
seanpdoyle
force-pushed
the
conditionally-invoke-bower
branch
from
02afd8f
to
34ff6dd
Compare
|
This just broke my Semaphore CI build with the following even though I have Since this is a breaking change, shouldn't it have been part of a minor version bump? |
|
@jdurand could you try CI again, depending on If that succeeds, we'll publish a bugfix version for |
|
Yes, Note that I was able to fix this by running //package.json
{
"scripts": {
"postinstall": "bower install"
}
}This could be the 0.9.x way to go as long as it's mentioned in the README and/or CHANGELOG. |
This reverts commit 34ff6dd, so that it can be reintroduced as a + breaking change, [requiring a major version bump][#532-comment]. [#532-comment]: #532 (comment)
This reverts commit 34ff6dd, so that it can be reintroduced as a + breaking change, [requiring a major version bump][tricknotes#532-comment]. [tricknotes#532-comment]: tricknotes#532 (comment)
Closes #531.
According to
bowerwarning messages, the project is semi-deprecated:As such, the build process will skip
bower installand won't require abowerif the application'sbower.jsonfile is missing.