Remove dependency on tee command
#420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| err = StringIO.new | ||
| runner = EmberCli::Runner.new(err: err, out: out) | ||
| it "writes to all `err` and `out` streams" do | ||
| output_streams = 4.times.map { StringIO.new } |
There was a problem hiding this comment.
Use Array.new with a block instead of .times.map.
This was referenced Mar 18, 2016
Closes [#417]. Instead of piping output to the [`tee`][tee] command (which was previously swallowing non-zero exit statuses), capture output from `Open3.capture2e` and write to both the specified log file and `STDOUT`. [#417]: #417 [tee]: http://man7.org/linux/man-pages/man1/tee.1.html
|
This is my favorite solution yet. |
|
I really like "faking" an IO object that than writes out to multiple other IO objects ... ❤️ the approach! The approach is working for me 👍 The only thing that is happening now, is that it tries to compile all three of our ember apps before failing ... But this is totally fine and I don't think it's worth to putting in any more efforts for fixing this ;)
Thanks @seanpdoyle for all the efforts!!! I cannot thank you enough for getting this sorted out! Should we keep this branch in our Gemfile or can we expect a release soon? |
|
@klaustopher once CI is green, we'll merge this into
This is unintended behavior. I'd like to resolve this before cutting a release. |
|
@seanpdoyle That sounds good. Let me know when you have pushed some changes so I can test. Will be available in the next 2 hours. |
| end | ||
|
|
||
| def write_to_err(output) | ||
| write(out_streams + err_streams, output) |
There was a problem hiding this comment.
@thoughtbot/shell does it make sense to write errors to both STDERR and STDOUT?
I'm having trouble using git blame to find the commit that introduced (and justified) this behavior (this PR is only a refactoring of the behavior).
Is it unconventional to only log errors to STDERR?
There was a problem hiding this comment.
Just one, please. It makes the most sense to send errors to stderr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #417.
Instead of piping output to the
teecommand (which waspreviously swallowing non-zero exit statuses), capture output
from
Open3.capture2eand write to both the specified log file andSTDOUT.