Remove dependency on Sprockets #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,10 +14,15 @@ def mount_ember_app(app_name, to:, **options) | |||
| format: :html, | |||
| ) | |||
|
|
|||
| dist_directory = EmberCli[app_name].paths.dist | |||
|
|
|||
|
|
|||
seanpdoyle
force-pushed
the
remove-sprockets
branch
14 times, most recently
from
7264f14
to
30585cb
Compare
seanpdoyle
force-pushed
the
remove-sprockets
branch
from
30585cb
to
5dd9e5e
Compare
seanpdoyle
force-pushed
the
remove-sprockets
branch
from
5dd9e5e
to
5745c4b
Compare
seanpdoyle
force-pushed
the
remove-sprockets
branch
2 times, most recently
from
9d51d9d
to
3a7b0a5
Compare
Completely separate EmberCLI's build process from Rails and Sprockets'. `mount_ember_app` uses [`Rack::File`][rack-file] to serve the EmberCLI application's `dist/` directory. No longer serve EmberCLI-generated assets through asset pipeline. Instead, generate URLs pointing directly to `Rack::File` assets. Unfortunately, EmberCLI fingerprint prepending isn't supported with the `include_` style helpers. [rack-file]: http://www.rubydoc.info/github/rack/rack/Rack/File
seanpdoyle
force-pushed
the
remove-sprockets
branch
from
3a7b0a5
to
68fa4f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely separate EmberCLI's build process from Rails and Sprockets'.
mount_ember_appusesRack::Fileto serve the EmberCLIapplication's
dist/directory.No longer serve EmberCLI-generated assets through asset pipeline.
Instead, generate URLs pointing directly to
Rack::Fileassets.Unfortunately, EmberCLI fingerprint prepending isn't supported with the
include_style helpers.