Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest EmberCLI-generated asset files #316

Merged
merged 1 commit into from
Dec 3, 2015
Merged

Conversation

seanpdoyle
Copy link
Contributor

Closes #298

Use Sprockets-generated manifest to detect which files are the most up
to date versions of EmberCLI-generated assets.

No longer support Sprockets-based helpers for Rails 3.2, given the
difference in how the Asset Pipeline works post-4.0.

},
"files" => {
"foo.js" => "foo.js",
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put a comma after the last parameter of a multiline method call.

@seanpdoyle seanpdoyle force-pushed the sd-manifest branch 3 times, most recently from ade6422 to 10894b7 Compare December 1, 2015 04:04
def stub_rails_manifest(manifest_hash)
assets_manifest = Sprockets::Manifest.new(
"test",
create_manifest_file(manifest_hash)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put a comma after the last parameter of a multiline method call.

@seanpdoyle seanpdoyle force-pushed the sd-manifest branch 15 times, most recently from ec6a05d to 64cc324 Compare December 2, 2015 18:51
@seanpdoyle seanpdoyle changed the title Merge EmberCLI-generated Manifest with Sprockets' Use latest EmberCLI-generated asset files Dec 2, 2015
Closes [#298]

Use Sprockets-generated manifest to detect which files are the most up
to date versions of EmberCLI-generated assets.

No longer support Sprockets-based helpers for Rails 3.2, given the
difference in how the Asset Pipeline works post-4.0.

[#298]: #298
@seanpdoyle seanpdoyle merged commit 87c65e3 into master Dec 3, 2015
@seanpdoyle seanpdoyle deleted the sd-manifest branch December 3, 2015 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants