Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple workers cause multiple build servers and race conditions #94

Closed
rwz opened this issue Mar 3, 2015 · 7 comments
Closed

Multiple workers cause multiple build servers and race conditions #94

rwz opened this issue Mar 3, 2015 · 7 comments

Comments

@rwz
Copy link
Collaborator

rwz commented Mar 3, 2015

See issues #89 & #85.

@rwz
Copy link
Collaborator Author

rwz commented Mar 3, 2015

First thing I'd like to understand: why people are even using multiple workers in dev environment.

If this is something people do a lot for legit reasons, we probably need to build some sort of workaround to support it. If it's very specific and rare, well, in this case a warning in a README stating that the gem is designed to work in a single-worker environment should be enough.

@himynameisjonas
Copy link

We try to have the exact same environment in development as we have in production, therefor we run thin as web server in all environments.

@rondale-sc
Copy link
Collaborator

@himynameisjonas I was under the impression that Thin doesn't have multiple workers. iirc

@himynameisjonas
Copy link

@rondale-sc oh, my misstake. I hade multiple servers running at the same time (Used to start 4 instances with http://pow.cx ). With just one server running Thin work fine.

@himynameisjonas
Copy link

But i use the same server in dev/prod for the reason i wrote in my first comment, but in this case i'm lucky we're running Thin and not puma/unicorn :)

@rondale-sc
Copy link
Collaborator

@himynameisjonas Glad that worked out. This shouldn't be an issue with production deploys because all ember-cli-rails does (if you asset precompile) is make the assets available to Rails which it does only once per ember app not per request.

This is only a problem when multiple workers are being used in development, which is not the default for puma (iirc).

Closing this for now. In #86 @sevos had a solution for this listed in his comment. I think that should suffice. Adding that to the readme might be a good idea. (what do you think @sevos?)

Cheers 🍻

@seanpdoyle
Copy link
Contributor

@rondale-sc @rwz we use unicorn in development @ thoughtbot and we've recently run into this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants