Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to set field option as not sortable #1314

Closed
privorotskii opened this issue Apr 12, 2019 · 2 comments
Closed

Possibility to set field option as not sortable #1314

privorotskii opened this issue Apr 12, 2019 · 2 comments
Labels
feature new functionality that’s not yet implemented fields new fields, displaying and editing data search finding things through our models

Comments

@privorotskii
Copy link

It is possible to set field as searchable, but there is no field option to set it as sortable or not sortable. It could be useful for some cases - not each column at collection page has to be sortable by default.
May I create a PR for adding such option? It would be working like this:

  ...
  ATTRIBUTE_TYPES = {
    ...
    comment: Field::Text.with_options(sortable: false),
    ...
  }.freeze
  ...

So the heading of the 'comment' column at the collection page would not be clickable.
Or, may be, there is another way to do it I don't know about?

@nickcharlton nickcharlton added feature new functionality that’s not yet implemented search finding things through our models fields new fields, displaying and editing data labels Jan 2, 2020
@nickcharlton
Copy link
Member

I know it's been a long time — I think your PR fell aside somewhere — but if you're still interested in opening that PR that'd be great!

@pablobm
Copy link
Collaborator

pablobm commented Apr 4, 2023

Closing due to lack of activity. Still happy to review PRs about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new functionality that’s not yet implemented fields new fields, displaying and editing data search finding things through our models
Projects
None yet
Development

No branches or pull requests

3 participants