From 216d42f3c1787839518c3787acfffcfd162074a5 Mon Sep 17 00:00:00 2001 From: Tom Longhurst <30480171+thomhurst@users.noreply.github.com> Date: Thu, 28 May 2026 18:06:05 +0100 Subject: [PATCH 1/2] perf: use TryAdd in TestDependencyResolver dependency dedupe (#6042) --- TUnit.Engine/Services/TestDependencyResolver.cs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/TUnit.Engine/Services/TestDependencyResolver.cs b/TUnit.Engine/Services/TestDependencyResolver.cs index 0ef7b5e232..212ae57432 100644 --- a/TUnit.Engine/Services/TestDependencyResolver.cs +++ b/TUnit.Engine/Services/TestDependencyResolver.cs @@ -110,10 +110,7 @@ private bool ResolveDependenciesForTest(AbstractExecutableTest test) continue; } - if (!uniqueDependencies.ContainsKey(dep.Test)) - { - uniqueDependencies[dep.Test] = dep; - } + uniqueDependencies.TryAdd(dep.Test, dep); } test.Dependencies = uniqueDependencies.Values.ToArray(); From 57dc8bc5483edbb2c460624669c96389907e93a2 Mon Sep 17 00:00:00 2001 From: Tom Longhurst <30480171+thomhurst@users.noreply.github.com> Date: Thu, 28 May 2026 18:32:00 +0100 Subject: [PATCH 2/2] perf: also apply TryAdd in ResolveDependenciesForTestLockFree Mirror the dedupe substitution in the sibling lock-free batch path so both methods share the same TryAdd spelling. Per reviewer feedback on PR #6068. --- TUnit.Engine/Services/TestDependencyResolver.cs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/TUnit.Engine/Services/TestDependencyResolver.cs b/TUnit.Engine/Services/TestDependencyResolver.cs index 212ae57432..986332bb40 100644 --- a/TUnit.Engine/Services/TestDependencyResolver.cs +++ b/TUnit.Engine/Services/TestDependencyResolver.cs @@ -255,10 +255,7 @@ private void ResolveDependenciesForTestLockFree(AbstractExecutableTest test) continue; } - if (!uniqueDependencies.ContainsKey(dep.Test)) - { - uniqueDependencies[dep.Test] = dep; - } + uniqueDependencies.TryAdd(dep.Test, dep); } test.Dependencies = uniqueDependencies.Values.ToArray();