Skip to content

fix: force synchronous library module initializer completion #4630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 11 commits into from
Feb 1, 2026
Merged

fix: force synchronous library module initializer completion #4630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
17bb06b
fix: force synchronous library module initializer completion
thomhurst Jan 31, 2026
0c5cee8
feat: add assembly name to module initializer logs for debugging
thomhurst Jan 31, 2026
d2cb6da
fix: force TUnit.Core to load before accessing its types
thomhurst Jan 31, 2026
a58af3b
feat: add defensive logging with try-catch for safety
thomhurst Jan 31, 2026
fe5dff7
fix: wrap TUnit.Core loading in try-catch to prevent FileNotFoundExce…
thomhurst Jan 31, 2026
3eb2985
feat: add MinVer for automatic version calculation from git tags
thomhurst Jan 31, 2026
c1a0df9
fix: remove duplicate MinVer PackageVersion entry
thomhurst Jan 31, 2026
12bfef3
fix: wrap all TUnit.Core references in defensive try-catch
thomhurst Jan 31, 2026
0faefbd
fix: configure MinVer to set AssemblyVersion from git tags
thomhurst Jan 31, 2026
25f4197
fix: skip AssemblyVersion target during pack operations
thomhurst Jan 31, 2026
9ea1ec4
fix: skip MinVer during pack operations
thomhurst Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .github/workflows/claude-code-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,19 @@ jobs:
claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
plugin_marketplaces: 'https://github.com/anthropics/claude-code.git'
plugins: 'code-review@claude-code-plugins'
prompt: '/code-review:code-review ${{ github.repository }}/pull/${{ github.event.pull_request.number || inputs.pr_number }}'
prompt: |
/code-review:code-review ${{ github.repository }}/pull/${{ github.event.pull_request.number || inputs.pr_number }}

Additional instructions:
- ALWAYS post a review comment, even if no issues are found. If the code is good, acknowledge it.
- When you find issues, ALWAYS suggest better approaches or architectural improvements, not just minor optimizations.
- Focus on:
* Design patterns that could be improved
* Alternative approaches that are more maintainable or scalable
* Architectural concerns or anti-patterns
* Better abstractions or simplifications
- Skip minor style/formatting issues unless they impact readability significantly.
- Always explain WHY the suggested approach is better, not just WHAT to change.
# See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md
# or https://code.claude.com/docs/en/cli-reference for available options

10 changes: 10 additions & 0 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,18 @@
<PropertyGroup>
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
</PropertyGroup>
<PropertyGroup>
<!-- Configure MinVer to recognize tags with 'v' prefix (v1.12.102) -->
<MinVerTagPrefix>v</MinVerTagPrefix>
<!-- Skip MinVer during pack operations - pack module provides explicit versioning -->
<MinVerSkip Condition="'$(IsPackTarget)' == 'true'">true</MinVerSkip>
</PropertyGroup>
<ItemGroup>
<GlobalPackageReference Include="Microsoft.SourceLink.GitHub" Version="10.0.102" />
<GlobalPackageReference Include="MinVer" Version="6.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</GlobalPackageReference>
</ItemGroup>
<ItemGroup>
<PackageVersion Include="AutoFixture" Version="4.18.1" />
Expand Down
2 changes: 1 addition & 1 deletion Library.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

<IsAotCompatible
Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0'))">true</IsAotCompatible>

<SignAssembly>true</SignAssembly>
<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)strongname.snk</AssemblyOriginatorKeyFile>
<PublicKey>0024000004800000940000000602000000240000525341310004000001000100698a70398fa0b2230c5a72e3bd9d56b48f809f6173e49a19fbb942d621be93ad48c5566b47b28faabc359b9ad3ff4e00bbdea88f5bdfa250f391fedd28182b2e37b55d429c0151a42a98ea7a5821818cd15a79fef9903e8607a88304cf3e0317bf86ec96e32e1381535a6582251e5a6eed40b5a3ed82bc444598b1269cce57a7</PublicKey>
Expand Down
12 changes: 12 additions & 0 deletions Library.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,16 @@
<Project>
<Import
Project="$(MSBuildThisFileDirectory)Polyfill.targets" />

<!-- Set AssemblyVersion to match MinVer calculated version before assembly info generation -->
<!-- Skip during pack operations to avoid interfering with NuGet versioning (IsPackTarget=true) -->
<Target Name="SetAssemblyVersionFromMinVer"
BeforeTargets="GetAssemblyVersion;GenerateAssemblyInfo"
Condition="'$(MinVerVersion)' != '' and '$(IsPackTarget)' != 'true'">
<PropertyGroup>
<AssemblyVersion>$(MinVerMajor).$(MinVerMinor).$(MinVerPatch).0</AssemblyVersion>
<FileVersion>$(MinVerMajor).$(MinVerMinor).$(MinVerPatch).0</FileVersion>
</PropertyGroup>
<Message Importance="high" Text="Setting AssemblyVersion to $(AssemblyVersion)" />
</Target>
</Project>
112 changes: 56 additions & 56 deletions TUnit.Core.SourceGenerator.Tests/ClassDataSourceDrivenTests.Test.verified.txt
View file
Open in desktop

Large diffs are not rendered by default.

22 changes: 11 additions & 11 deletions TUnit.Core.SourceGenerator.Tests/ClassDataSourceDrivenTestsSharedKeyed.Test.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// <auto-generated/>
// <auto-generated/>
#pragma warning disable

#nullable enable
Expand All @@ -20,7 +20,7 @@ internal sealed class TUnit_TestProject_ClassDataSourceDrivenTestsSharedKeyed_Da
],
DataSources = new global::TUnit.Core.IDataSourceAttribute[]
{
new global::TUnit.Core.ClassDataSourceAttribute<SomeAsyncDisposableClass>()
new global::TUnit.Core.ClassDataSourceAttribute<global::TUnit.TestProject.Library.Models.SomeAsyncDisposableClass>()
{Shared = global::TUnit.Core.SharedType.Keyed,Key = "🔑",},
},
ClassDataSources = global::System.Array.Empty<global::TUnit.Core.IDataSourceAttribute>(),
Expand All @@ -39,12 +39,12 @@ internal sealed class TUnit_TestProject_ClassDataSourceDrivenTestsSharedKeyed_Da
ReturnTypeInfo = new global::TUnit.Core.ConcreteType(typeof(void)),
Parameters = new global::TUnit.Core.ParameterMetadata[]
{
new global::TUnit.Core.ParameterMetadata(typeof(SomeAsyncDisposableClass))
new global::TUnit.Core.ParameterMetadata(typeof(global::TUnit.TestProject.Library.Models.SomeAsyncDisposableClass))
{
Name = "value",
TypeInfo = new global::TUnit.Core.ConcreteType(typeof(SomeAsyncDisposableClass)),
TypeInfo = new global::TUnit.Core.ConcreteType(typeof(global::TUnit.TestProject.Library.Models.SomeAsyncDisposableClass)),
IsNullable = false,
ReflectionInfo = typeof(global::TUnit.TestProject.ClassDataSourceDrivenTestsSharedKeyed).GetMethod("DataSource_Class", global::System.Reflection.BindingFlags.Public | global::System.Reflection.BindingFlags.NonPublic | global::System.Reflection.BindingFlags.Instance, null, new global::System.Type[] { typeof(SomeAsyncDisposableClass) }, null)!.GetParameters()[0]
ReflectionInfo = typeof(global::TUnit.TestProject.ClassDataSourceDrivenTestsSharedKeyed).GetMethod("DataSource_Class", global::System.Reflection.BindingFlags.Public | global::System.Reflection.BindingFlags.NonPublic | global::System.Reflection.BindingFlags.Instance, null, new global::System.Type[] { typeof(global::TUnit.TestProject.Library.Models.SomeAsyncDisposableClass) }, null)!.GetParameters()[0]
}
},
Class = global::TUnit.Core.ClassMetadata.GetOrAdd("TestsBase`1:global::TUnit.TestProject.ClassDataSourceDrivenTestsSharedKeyed", static () =>
Expand Down Expand Up @@ -72,7 +72,7 @@ internal sealed class TUnit_TestProject_ClassDataSourceDrivenTestsSharedKeyed_Da
{
case 1:
{
instance.DataSource_Class(global::TUnit.Core.Helpers.CastHelper.Cast<SomeAsyncDisposableClass>(args[0]));
instance.DataSource_Class(global::TUnit.Core.Helpers.CastHelper.Cast<global::TUnit.TestProject.Library.Models.SomeAsyncDisposableClass>(args[0]));
return default(global::System.Threading.Tasks.ValueTask);
}
default:
Expand Down Expand Up @@ -142,7 +142,7 @@ internal sealed class TUnit_TestProject_ClassDataSourceDrivenTestsSharedKeyed_Da
],
DataSources = new global::TUnit.Core.IDataSourceAttribute[]
{
new global::TUnit.Core.ClassDataSourceAttribute<SomeAsyncDisposableClass>()
new global::TUnit.Core.ClassDataSourceAttribute<global::TUnit.TestProject.Library.Models.SomeAsyncDisposableClass>()
{Shared = global::TUnit.Core.SharedType.Keyed,Key = "🔑",},
},
ClassDataSources = global::System.Array.Empty<global::TUnit.Core.IDataSourceAttribute>(),
Expand All @@ -161,12 +161,12 @@ internal sealed class TUnit_TestProject_ClassDataSourceDrivenTestsSharedKeyed_Da
ReturnTypeInfo = new global::TUnit.Core.ConcreteType(typeof(void)),
Parameters = new global::TUnit.Core.ParameterMetadata[]
{
new global::TUnit.Core.ParameterMetadata(typeof(SomeAsyncDisposableClass))
new global::TUnit.Core.ParameterMetadata(typeof(global::TUnit.TestProject.Library.Models.SomeAsyncDisposableClass))
{
Name = "value",
TypeInfo = new global::TUnit.Core.ConcreteType(typeof(SomeAsyncDisposableClass)),
TypeInfo = new global::TUnit.Core.ConcreteType(typeof(global::TUnit.TestProject.Library.Models.SomeAsyncDisposableClass)),
IsNullable = false,
ReflectionInfo = typeof(global::TUnit.TestProject.ClassDataSourceDrivenTestsSharedKeyed).GetMethod("DataSource_Class_Generic", global::System.Reflection.BindingFlags.Public | global::System.Reflection.BindingFlags.NonPublic | global::System.Reflection.BindingFlags.Instance, null, new global::System.Type[] { typeof(SomeAsyncDisposableClass) }, null)!.GetParameters()[0]
ReflectionInfo = typeof(global::TUnit.TestProject.ClassDataSourceDrivenTestsSharedKeyed).GetMethod("DataSource_Class_Generic", global::System.Reflection.BindingFlags.Public | global::System.Reflection.BindingFlags.NonPublic | global::System.Reflection.BindingFlags.Instance, null, new global::System.Type[] { typeof(global::TUnit.TestProject.Library.Models.SomeAsyncDisposableClass) }, null)!.GetParameters()[0]
}
},
Class = global::TUnit.Core.ClassMetadata.GetOrAdd("TestsBase`1:global::TUnit.TestProject.ClassDataSourceDrivenTestsSharedKeyed", static () =>
Expand Down Expand Up @@ -194,7 +194,7 @@ internal sealed class TUnit_TestProject_ClassDataSourceDrivenTestsSharedKeyed_Da
{
case 1:
{
instance.DataSource_Class_Generic(global::TUnit.Core.Helpers.CastHelper.Cast<SomeAsyncDisposableClass>(args[0]));
instance.DataSource_Class_Generic(global::TUnit.Core.Helpers.CastHelper.Cast<global::TUnit.TestProject.Library.Models.SomeAsyncDisposableClass>(args[0]));
return default(global::System.Threading.Tasks.ValueTask);
}
default:
Expand Down
Loading
Loading