Skip to content

fix: pass empty array to params parameter when [Arguments] has no values #4572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
Jan 27, 2026
+16 −1
Merged

fix: pass empty array to params parameter when [Arguments] has no values #4572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion TUnit.Core/Attributes/TestData/ArgumentsAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,14 @@ public sealed class ArgumentsAttribute : Attribute, IDataSourceAttribute, ITestR

public ArgumentsAttribute(params object?[]? values)
{
if (values == null || values.Length == 0)
if (values == null)
{
Values = [null];
}
else if (values.Length == 0)
{
Values = [];
}
else
{
Values = values;
Expand Down
11 changes: 11 additions & 0 deletions TUnit.TestProject/ParamsArgumentsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,17 @@ public async Task EmptyParamsArray(string name, params Type[] types)
await Assert.That(types.Length).IsEqualTo(0);
}

[Test]
[Arguments]
[Arguments("a")]
[Arguments("a", "b")]
[Arguments("a", "b", "c")]
public async Task ParamsOnlyWithEmptyArguments(params string[] args)
{
// When [Arguments] has no values, params should be an empty array, not null
await Assert.That(args).IsNotNull();
}

[Test]
[Arguments(1, "single")]
public async Task SingleStringInParamsArray(int id, params string[] values)
Expand Down
Loading