Skip to content

perf: cache CreateExecutableTestFactory delegate #4292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 2 commits into from
Jan 10, 2026
Merged

perf: cache CreateExecutableTestFactory delegate #4292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
984b19c
chore: add .worktrees/ to gitignore
thomhurst Jan 10, 2026
974dacd
perf: cache CreateExecutableTestFactory delegate
thomhurst Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,4 +435,7 @@ doc/plans/
*speedscope*.json

# Dotnet trace files
*.nettrace
*.nettrace

# Git worktrees
.worktrees/
11 changes: 10 additions & 1 deletion TUnit.Core/TestMetadata`1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ public class TestMetadata<
{
private Func<Type[], object?[], T>? _instanceFactory;
private Func<T, object?[], Task>? _testInvoker;
private Func<ExecutableTestCreationContext, TestMetadata, AbstractExecutableTest>? _cachedExecutableTestFactory;

/// <summary>
/// Strongly typed instance factory
Expand Down Expand Up @@ -63,10 +64,16 @@ public override Func<ExecutableTestCreationContext, TestMetadata, AbstractExecut
{
get
{
// Return cached factory if available
if (_cachedExecutableTestFactory != null)
{
return _cachedExecutableTestFactory;
}

// For AOT mode, create delegates from the strongly-typed ones
if (InstanceFactory != null && InvokeTypedTest != null)
{
return (context, metadata) =>
_cachedExecutableTestFactory = (context, metadata) =>
{
var typedMetadata = (TestMetadata<T>)metadata;

Expand Down Expand Up @@ -109,6 +116,8 @@ public override Func<ExecutableTestCreationContext, TestMetadata, AbstractExecut
Context = context.Context
};
};

return _cachedExecutableTestFactory;
}

throw new InvalidOperationException($"InstanceFactory and InvokeTypedTest must be set for {typeof(T).Name}");
Expand Down
Loading