Skip to content

perf: skip List creation in GetDynamicTestAttributes #4195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
Jan 7, 2026
Merged

perf: skip List creation in GetDynamicTestAttributes #4195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions TUnit.Engine/Building/Collectors/AotTestDataCollector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,15 +155,17 @@ private Task<TestMetadata> CreateMetadataFromDynamicDiscoveryResult(DynamicDisco

private static Attribute[] GetDynamicTestAttributes(DynamicDiscoveryResult result)
{
if (result.TestClassType == null)
{
return result.Attributes.ToArray();
}

// Merge explicitly provided attributes with inherited class/assembly attributes
// Order matches GetAllAttributes: method-level first (explicit), then class, then assembly
var attributes = new List<Attribute>(result.Attributes);

if (result.TestClassType != null)
{
attributes.AddRange(result.TestClassType.GetCustomAttributes().OfType<Attribute>());
attributes.AddRange(result.TestClassType.Assembly.GetCustomAttributes().OfType<Attribute>());
}
attributes.AddRange(result.TestClassType.GetCustomAttributes());
attributes.AddRange(result.TestClassType.Assembly.GetCustomAttributes());

return attributes.ToArray();
}
Expand Down
12 changes: 7 additions & 5 deletions TUnit.Engine/Discovery/ReflectionTestDataCollector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1932,15 +1932,17 @@ private Task<TestMetadata> CreateMetadataFromDynamicDiscoveryResult(DynamicDisco

private static Attribute[] GetDynamicTestAttributes(DynamicDiscoveryResult result)
{
if (result.TestClassType == null)
{
return result.Attributes.ToArray();
}

// Merge explicitly provided attributes with inherited class/assembly attributes
// Order matches GetAllAttributes: method-level first (explicit), then class, then assembly
var attributes = new List<Attribute>(result.Attributes);

if (result.TestClassType != null)
{
attributes.AddRange(result.TestClassType.GetCustomAttributes().OfType<Attribute>());
attributes.AddRange(result.TestClassType.Assembly.GetCustomAttributes().OfType<Attribute>());
}
attributes.AddRange(result.TestClassType.GetCustomAttributes());
attributes.AddRange(result.TestClassType.Assembly.GetCustomAttributes());

return attributes.ToArray();
}
Expand Down
Loading