Skip to content

Allow injecting mix-and-match data sources to different parameters #3636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 1, 2025
Merged

Allow injecting mix-and-match data sources to different parameters #3636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0ef2e21
Allow injecting mix-and-match data sources to different parameters
thomhurst Nov 1, 2025
12b8734
feat: Introduce CombinedDataSource attribute for flexible data-driven…
thomhurst Nov 1, 2025
efe199b
Fix docs broken links
thomhurst Nov 1, 2025
37e1bfb
refactor: Update CombinedDataSourceAttribute to support asynchronous …
thomhurst Nov 1, 2025
df9c28d
feat: Enhance AOT compatibility by introducing cached data source att…
thomhurst Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
324 changes: 324 additions & 0 deletions TUnit.Analyzers.Tests/CombinedDataSourceAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,324 @@
using Verifier = TUnit.Analyzers.Tests.Verifiers.CSharpAnalyzerVerifier<TUnit.Analyzers.CombinedDataSourceAnalyzer>;

namespace TUnit.Analyzers.Tests;

public class CombinedDataSourceAnalyzerTests
{
[Test]
public async Task Method_With_CombinedDataSource_And_ParameterDataSources_No_Error()
{
await Verifier
.VerifyAnalyzerAsync(
"""
using TUnit.Core;

public class MyClass
{
[CombinedDataSource]
[Test]
public void MyTest(
[Arguments(1, 2, 3)] int value,
[Arguments("a", "b")] string text
)
{
}
}
"""
);
}

[Test]
public async Task Method_With_ParameterDataSources_Missing_CombinedDataSource_Error()
{
await Verifier
.VerifyAnalyzerAsync(
"""
using TUnit.Core;

public class MyClass
{
[Test]
public void {|#0:MyTest|}(
[Arguments(1, 2, 3)] int value,
[Arguments("a", "b")] string text
)
{
}
}
""",
Verifier.Diagnostic(Rules.CombinedDataSourceAttributeRequired)
.WithLocation(0)
);
}

[Test]
public async Task Method_With_CombinedDataSource_Missing_ParameterDataSource_Error()
{
await Verifier
.VerifyAnalyzerAsync(
"""
using TUnit.Core;

public class MyClass
{
[CombinedDataSource]
[Test]
public void MyTest(
[Arguments(1, 2, 3)] int value,
string {|#0:text|}
)
{
}
}
""",
Verifier.Diagnostic(Rules.CombinedDataSourceMissingParameterDataSource)
.WithLocation(0)
.WithArguments("text")
);
}

[Test]
public async Task Method_With_CombinedDataSource_And_MatrixDataSource_Warning()
{
await Verifier
.VerifyAnalyzerAsync(
"""
using TUnit.Core;

public class MyClass
{
[CombinedDataSource]
[MatrixDataSource]
[Test]
public void {|#0:MyTest|}(
[Arguments(1, 2, 3)] int value,
[Arguments("a", "b")] string text
)
{
}
}
""",
Verifier.Diagnostic(Rules.CombinedDataSourceConflictWithMatrix)
.WithLocation(0)
);
}

[Test]
public async Task Class_With_CombinedDataSource_And_ParameterDataSources_No_Error()
{
await Verifier
.VerifyAnalyzerAsync(
"""
using TUnit.Core;

[CombinedDataSource]
public class MyClass
{
public MyClass(
[Arguments(1, 2, 3)] int value,
[Arguments("a", "b")] string text
)
{
}

[Test]
public void MyTest()
{
}
}
"""
);
}

[Test]
public async Task Class_With_ParameterDataSources_Missing_CombinedDataSource_Error()
{
await Verifier
.VerifyAnalyzerAsync(
"""
using TUnit.Core;

public class {|#0:MyClass|}
{
public MyClass(
[Arguments(1, 2, 3)] int value,
[Arguments("a", "b")] string text
)
{
}

[Test]
public void MyTest()
{
}
}
""",
Verifier.Diagnostic(Rules.CombinedDataSourceAttributeRequired)
.WithLocation(0)
);
}

[Test]
public async Task Method_With_CancellationToken_No_DataSource_Required()
{
await Verifier
.VerifyAnalyzerAsync(
"""
using System.Threading;
using TUnit.Core;

public class MyClass
{
[CombinedDataSource]
[Test]
public void MyTest(
[Arguments(1, 2, 3)] int value,
CancellationToken cancellationToken
)
{
}
}
"""
);
}

[Test]
public async Task Method_With_MethodDataSource_And_Arguments_No_Error()
{
await Verifier
.VerifyAnalyzerAsync(
"""
using TUnit.Core;
using System.Collections.Generic;

public class MyClass
{
public static IEnumerable<int> GetNumbers() => [1, 2, 3];

[CombinedDataSource]
[Test]
public void MyTest(
[MethodDataSource(nameof(GetNumbers))] int number,
[Arguments("a", "b")] string text
)
{
}
}
"""
);
}

[Test]
public async Task Method_With_ClassDataSource_No_Error()
{
await Verifier
.VerifyAnalyzerAsync(
"""
using TUnit.Core;
using System.Collections.Generic;
using System;

public class TestData : DataSourceGeneratorAttribute<int>
{
protected override IEnumerable<Func<int>> GenerateDataSources(DataGeneratorMetadata dataGeneratorMetadata)
{
yield return () => 1;
yield return () => 2;
}
}

public class MyClass
{
[CombinedDataSource]
[Test]
public void MyTest(
[ClassDataSource<TestData>] int number,
[Arguments("a", "b")] string text
)
{
}
}
"""
);
}

[Test]
public async Task Method_Multiple_Parameters_Missing_DataSource_Multiple_Errors()
{
await Verifier
.VerifyAnalyzerAsync(
"""
using TUnit.Core;

public class MyClass
{
[CombinedDataSource]
[Test]
public void MyTest(
[Arguments(1, 2, 3)] int value,
string {|#0:text|},
bool {|#1:flag|}
)
{
}
}
""",
Verifier.Diagnostic(Rules.CombinedDataSourceMissingParameterDataSource)
.WithLocation(0)
.WithArguments("text"),
Verifier.Diagnostic(Rules.CombinedDataSourceMissingParameterDataSource)
.WithLocation(1)
.WithArguments("flag")
);
}

[Test]
public async Task Method_Without_CombinedDataSource_No_ParameterDataSources_No_Error()
{
await Verifier
.VerifyAnalyzerAsync(
"""
using TUnit.Core;

public class MyClass
{
[Test]
[Arguments(1, "a", true)]
public void MyTest(int value, string text, bool flag)
{
}
}
"""
);
}

[Test]
public async Task Class_With_CombinedDataSource_Missing_ParameterDataSource_Error()
{
await Verifier
.VerifyAnalyzerAsync(
"""
using TUnit.Core;

[CombinedDataSource]
public class MyClass
{
public MyClass(
[Arguments(1, 2, 3)] int value,
string {|#0:text|}
)
{
}

[Test]
public void MyTest()
{
}
}
""",
Verifier.Diagnostic(Rules.CombinedDataSourceMissingParameterDataSource)
.WithLocation(0)
.WithArguments("text")
);
}
}
Loading
Loading