Improve loading state #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomheymann
pushed a commit
that referenced
this pull request
Jun 12, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [whatwg-fetch](https://github.com/github/fetch) | dependencies | minor | [`^3.0.0` -> `^3.6.20`](https://renovatebot.com/diffs/npm/whatwg-fetch/3.0.0/3.6.20) | --- ### Release Notes <details> <summary>github/fetch (whatwg-fetch)</summary> ### [`v3.6.20`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#3620-2023-12-13) [Compare Source](https://github.com/github/fetch/compare/v3.6.19...v3.6.20) ##### Bug Fixes - Response.error().ok === false ([#&elastic#8203;1412](https://github.com/JakeChampion/fetch/issues/1412)) ([27e1c75](https://github.com/JakeChampion/fetch/commit/27e1c75f830f0b70a40b511e03652776951aca75)) ### [`v3.6.19`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#3619-2023-09-11) [Compare Source](https://github.com/github/fetch/compare/v3.6.18...v3.6.19) ##### Bug Fixes - Have unique error messages for xhr timeouts and errors ([#&elastic#8203;1380](https://github.com/JakeChampion/fetch/issues/1380)) ([7170f0b](https://github.com/JakeChampion/fetch/commit/7170f0b127d16c5895aba61c9168482834809046)) ### [`v3.6.18`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v3618) [Compare Source](https://github.com/github/fetch/compare/v3.6.17...v3.6.18) - Fix - File fetching broken since commit [`0c1d2b9`](https://github.com/github/fetch/commit/0c1d2b9) [`elastic#1375`](https://github.com/JakeChampion/fetch/pull/1375) - Remove broken links [`1dc07c6`](https://github.com/JakeChampion/fetch/commit/1dc07c6064a32e989306fb2324204c56c93140fe) - automatically generate a changelog [`0e7d1dd`](https://github.com/JakeChampion/fetch/commit/0e7d1dd95826b3b76510f0832784207f2609145e) ### [`v3.6.17`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v3617) [Compare Source](https://github.com/github/fetch/compare/v3.6.16...v3.6.17) > 20 July 2023 - Revert "Resolves [https://github.com/JakeChampion/fetch/issues/928](https://github.com/JakeChampion/fetch/issues/928)" [`elastic#928`](https://github.com/JakeChampion/fetch/issues/928) ### [`v3.6.16`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v3616) [Compare Source](https://github.com/github/fetch/compare/v3.6.15...v3.6.16) > 18 July 2023 - Resolves [https://github.com/JakeChampion/fetch/issues/928](https://github.com/JakeChampion/fetch/issues/928) [`elastic#928`](https://github.com/JakeChampion/fetch/issues/928) ### [`v3.6.15`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v3615) [Compare Source](https://github.com/github/fetch/compare/v3.6.14...v3.6.15) > 18 July 2023 - fix [https://github.com/JakeChampion/fetch/issues/997](https://github.com/JakeChampion/fetch/issues/997) [`elastic#997`](https://github.com/JakeChampion/fetch/issues/997) ### [`v3.6.14`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v3614) [Compare Source](https://github.com/github/fetch/compare/v3.6.13...v3.6.14) > 18 July 2023 - Fix [https://github.com/JakeChampion/fetch/issues/1076](https://github.com/JakeChampion/fetch/issues/1076) [`elastic#1076`](https://github.com/JakeChampion/fetch/issues/1076) ### [`v3.6.13`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v3613) [Compare Source](https://github.com/github/fetch/compare/v3.6.12...v3.6.13) > 18 July 2023 - respect charset within readBlobAsText [`elastic#1059`](https://github.com/JakeChampion/fetch/issues/1059) ### [`v3.6.12`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v3612) [Compare Source](https://github.com/github/fetch/compare/v3.6.11...v3.6.12) > 18 July 2023 - fix: Headers only accepts array which have nested array of length 2 [`elastic#1235`](https://github.com/JakeChampion/fetch/issues/1235) ### [`v3.6.11`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v3611) [Compare Source](https://github.com/github/fetch/compare/v3.6.10...v3.6.11) > 18 July 2023 - Define Body.arrayBuffer even if support.blob is false [`elastic#992`](https://github.com/JakeChampion/fetch/issues/992) ### [`v3.6.10`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v3610) [Compare Source](https://github.com/github/fetch/compare/v3.6.9...v3.6.10) > 18 July 2023 - use globals if they exist [`dffc542`](https://github.com/JakeChampion/fetch/commit/dffc542fe7140f35ee7fec29e3da67f3bf080910) ### [`v3.6.9`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v369) [Compare Source](https://github.com/github/fetch/compare/v3.6.8...v3.6.9) > 18 July 2023 - fix: when no body supplied, do not set bodyUsed to true [`7d92dff`](https://github.com/JakeChampion/fetch/commit/7d92dff12d7c4058b57c7e77adeb0a76ffab639f) ### [`v3.6.8`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v368) [Compare Source](https://github.com/github/fetch/compare/v3.6.7...v3.6.8) > 18 July 2023 - validate status is in range [`elastic#1213`](https://github.com/JakeChampion/fetch/issues/1213) ### [`v3.6.7`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v367) [Compare Source](https://github.com/github/fetch/compare/v3.6.6...v3.6.7) > 18 July 2023 - dont shadow `global` [`elastic#1026`](https://github.com/JakeChampion/fetch/issues/1026) - dont use github eslint [`408d3b6`](https://github.com/JakeChampion/fetch/commit/408d3b60e27abef325dd898d899430c46a0012b2) - remove invalid-headers test [`e3f6590`](https://github.com/JakeChampion/fetch/commit/e3f65907924b7692af7c08cd92044456bc92ad8b) - Update lock.yml permissions [`e97321b`](https://github.com/JakeChampion/fetch/commit/e97321bc081e80275397fc4c7a990791aa8b3524) ### [`v3.6.6`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v366) [Compare Source](https://github.com/github/fetch/compare/v3.6.5...v3.6.6) > 18 July 2023 - fix: ignore not throw on invalid response headers [`elastic#930`](https://github.com/JakeChampion/fetch/issues/930) ### [`v3.6.5`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v365) [Compare Source](https://github.com/github/fetch/compare/v3.6.4...v3.6.5) > 18 July 2023 - Add some missed methods which should be normalized as uppercase [`a43b628`](https://github.com/JakeChampion/fetch/commit/a43b6283833c403230bb1a5238e2d7ac435c52da) - Update caniuse link to use HTTPS and new pattern [`fb5b0cf`](https://github.com/JakeChampion/fetch/commit/fb5b0cf42b470faf8c5448ab461d561f34380a30) ### [`v3.6.4`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v364) [Compare Source](https://github.com/github/fetch/compare/v3.6.3...v3.6.4) > 18 July 2023 - always set a signal on Request [`d1d09fb`](https://github.com/JakeChampion/fetch/commit/d1d09fb8039b4b8c7f2f5d6c844ea72d8a3cefe6) ### [`v3.6.3`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v363) [Compare Source](https://github.com/github/fetch/compare/v3.6.2...v3.6.3) > 18 July 2023 - Compatible global equals to the false [`7727e50`](https://github.com/JakeChampion/fetch/commit/7727e50493eafae9a7005f10f18f81e5bbcbfdd3) ### [`v3.6.2`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#3620-2023-12-13) [Compare Source](https://github.com/github/fetch/compare/v3.6.1...v3.6.2) ##### Bug Fixes - Response.error().ok === false ([#&elastic#8203;1412](https://github.com/JakeChampion/fetch/issues/1412)) ([27e1c75](https://github.com/JakeChampion/fetch/commit/27e1c75f830f0b70a40b511e03652776951aca75)) ### [`v3.6.1`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#3619-2023-09-11) [Compare Source](https://github.com/github/fetch/compare/v3.6.0...v3.6.1) ##### Bug Fixes - Have unique error messages for xhr timeouts and errors ([#&elastic#8203;1380](https://github.com/JakeChampion/fetch/issues/1380)) ([7170f0b](https://github.com/JakeChampion/fetch/commit/7170f0b127d16c5895aba61c9168482834809046)) ### [`v3.6.0`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v360) [Compare Source](https://github.com/github/fetch/compare/v3.5.0...v3.6.0) > 18 February 2021 - Fix statusText: undefined should give '' and null should give 'null' [`b5c8bd0`](https://github.com/JakeChampion/fetch/commit/b5c8bd0fee1530f1c204cc5c68b427a3498dbdad) - Represent non-stringified JSON request body as an \[object Object] string [`5c6b055`](https://github.com/JakeChampion/fetch/commit/5c6b055e6ae6f718f416c94bfcdc89693d0abdcb) - Fix eslint and eslint-plugin-github dependency conflicts [`190e698`](https://github.com/JakeChampion/fetch/commit/190e698f8e737ad751a11de60f6b8b3301fa557b) ### [`v3.5.0`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v350) [Compare Source](https://github.com/github/fetch/compare/v3.4.1...v3.5.0) > 6 November 2020 - Fixes [#&elastic#8203;748](https://github.com/github/fetch/issues/748) [`elastic#748`](https://github.com/JakeChampion/fetch/issues/748) - Create lock.yml [`8767781`](https://github.com/JakeChampion/fetch/commit/87677811d543cfb44b124e026b50f710e95017ec) ### [`v3.4.1`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v341) [Compare Source](https://github.com/github/fetch/compare/v3.4.0...v3.4.1) > 7 September 2020 - Add npmignore file to ensure we always publish the dist directory [`7ca02eb`](https://github.com/JakeChampion/fetch/commit/7ca02eb0234b0a61fd711d922b2e69d3c5390516) - Make the clean task remove the dist directory and the default task create it [`fd23745`](https://github.com/JakeChampion/fetch/commit/fd23745f3474cd23d88e5128d8bc74813be1aff0) ### [`v3.4.0`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v340) [Compare Source](https://github.com/github/fetch/compare/v3.3.1...v3.4.0) > 7 August 2020 - Use globalThis as the global object if it exists [`96c2651`](https://github.com/JakeChampion/fetch/commit/96c26512608a0081d493df4fc17da4394bd1b410) ### [`v3.3.1`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v331) [Compare Source](https://github.com/github/fetch/compare/v3.3.0...v3.3.1) > 4 August 2020 - rename variable to no longer shadow over function of same name [`c5db762`](https://github.com/JakeChampion/fetch/commit/c5db7621c3b1530683b8f706388d4ac210a2db02) - remove semicolon to pass linting [`f264aa5`](https://github.com/JakeChampion/fetch/commit/f264aa5704f7431c429ec16e6fdd3c7034c7f2d9) ### [`v3.3.0`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v330) [Compare Source](https://github.com/github/fetch/compare/v3.2.0...v3.3.0) > 4 August 2020 - Make Response.arrayBuffer() always resolve with a `ArrayBuffer` [`elastic#801`](https://github.com/github/fetch/issues/801) - Stop using top-level `this` to stop rollup warning [`elastic#802`](https://github.com/github/fetch/issues/802) - Recommend an AbortController polyfill which is fully synchronous [`elastic#800`](https://github.com/github/fetch/issues/800) - Add keepalive caveat [`elastic#780`](https://github.com/github/fetch/issues/780) - Throw a TypeError if Request or Response functions are called without `new` [`5ef028d`](https://github.com/JakeChampion/fetch/commit/5ef028d61f6c1543603cdacbe0f8a0f00d5957c0) - If headers are passed in via a Record then do not normalise the header names as part of the request [`b65ed60`](https://github.com/JakeChampion/fetch/commit/b65ed608604492d605df2d62cd4c5050e2a8d508) - Update fetch.js [`37b55c2`](https://github.com/JakeChampion/fetch/commit/37b55c27413b902cef4e629892424ae469fb1ea2) ### [`v3.2.0`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v320) [Compare Source](https://github.com/github/fetch/compare/v3.1.1...v3.2.0) > 9 July 2020 - Detect if DOMException exists via typeof instead of trying to call it and catching the exception which may get thrown [`elastic#724`](https://github.com/github/fetch/issues/724) - use `this` if `self` is not defined [`elastic#657`](https://github.com/github/fetch/issues/657) - create variable called `global` which is either `self` or `this` [`a0783a5`](https://github.com/JakeChampion/fetch/commit/a0783a5571018191578cc08d5b3bac61a0b64562) - Add support for no-cache and no-store via a cache-busting querystring parameter [`a0dcd85`](https://github.com/JakeChampion/fetch/commit/a0dcd853f8ed29d06a022f92c87c303bd0e1f1bf) - make global `this` correct when using rollup [`6e9fc0e`](https://github.com/JakeChampion/fetch/commit/6e9fc0ee026dd89d864c3d176c57789ee5615114) ### [`v3.1.1`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v311) [Compare Source](https://github.com/github/fetch/compare/v3.1.0...v3.1.1) > 8 July 2020 - check if Content-Type header exists prior to examining the value [`elastic#792`](https://github.com/JakeChampion/fetch/pull/792) - Move from Travis to GitHub Actions [`elastic#793`](https://github.com/JakeChampion/fetch/pull/793) ### [`v3.1.0`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v310) [Compare Source](https://github.com/github/fetch/compare/v3.0.1...v3.1.0) > 29 June 2020 ### [`v3.0.1`](https://github.com/github/fetch/blob/HEAD/CHANGELOG.md#v301) [Compare Source](https://github.com/github/fetch/compare/v3.0.0...v3.0.1) > 8 July 2020 - check if Content-Type header exists prior to examining the value [`elastic#792`](https://github.com/JakeChampion/fetch/pull/792) - Move from Travis to GitHub Actions [`elastic#793`](https://github.com/JakeChampion/fetch/pull/793) - Co-authored-by: Jake Champion \<[email protected]> [`elastic#575`](https://github.com/JakeChampion/fetch/pull/575) - work around IE XHR bug with '' URL Fixes [#&elastic#8203;618](https://github.com/github/fetch/issues/618) [`elastic#619`](https://github.com/JakeChampion/fetch/pull/619) - Allow exclamation mark as valid header character [`elastic#745`](https://github.com/JakeChampion/fetch/pull/745) - Avoid blob conversion for specific requests [`elastic#752`](https://github.com/JakeChampion/fetch/pull/752) - Compatibility for fetch-mock using proxy-pollyfill [`elastic#736`](https://github.com/JakeChampion/fetch/pull/736) - Change default statusText for Response [`elastic#698`](https://github.com/JakeChampion/fetch/pull/698) - Document more common pitfalls in the README [`elastic#734`](https://github.com/JakeChampion/fetch/pull/734) - field name can not by empty [`elastic#684`](https://github.com/JakeChampion/fetch/pull/684) - work around IE XHR bug with '' URL Fixes [#&elastic#8203;618](https://github.com/github/fetch/issues/618) ([#&elastic#8203;619](https://github.com/github/fetch/issues/619)) [`elastic#618`](https://github.com/JakeChampion/fetch/issues/618) - Clarify what parts of the standard we don't want to implement [`elastic#661`](https://github.com/JakeChampion/fetch/issues/661) - Document more caveats [`9a0bce2`](https://github.com/JakeChampion/fetch/commit/9a0bce23454cdd5beefd9d4c599664003573e581) - Fix issue [#&elastic#8203;533](https://github.com/github/fetch/issues/533) [`7f030fa`](https://github.com/JakeChampion/fetch/commit/7f030fab4d79433204331cefe365f5fbbab9e992) - Compatibility with newer eslint-plugin-github [`1821b74`](https://github.com/JakeChampion/fetch/commit/1821b74b808152d4d6e787c21165f2d569c2a7c4) ##### [v3.0.0](https://github.com/JakeChampion/fetch/compare/v2.0.4...v3.0.0) > 7 September 2018 - Add flow definitions [`elastic#654`](https://github.com/JakeChampion/fetch/pull/654) - Match spec behavior re: unsupported body type [`elastic#651`](https://github.com/JakeChampion/fetch/pull/651) - Update Karma and detect available browsers when testing [`elastic#652`](https://github.com/JakeChampion/fetch/pull/652) - Adopt Contributor Covenant Code of Conduct [`elastic#649`](https://github.com/JakeChampion/fetch/pull/649) - Change `credentials` default value to `same-origin` [`elastic#640`](https://github.com/JakeChampion/fetch/pull/640) - Switch test suite from PhantomJS to Karma [`elastic#626`](https://github.com/JakeChampion/fetch/pull/626) - Support abort API [`elastic#592`](https://github.com/JakeChampion/fetch/pull/592) - build/distribute as UMD [`elastic#616`](https://github.com/JakeChampion/fetch/pull/616) - Test signal reuse. Add AbortSignal polyfill. [`#2`](https://github.com/JakeChampion/fetch/pull/2) - Clear abort event listener for all xhr completion states. [`#1`](https://github.com/JakeChampion/fetch/pull/1) - Expand install & importing documentation [`elastic#569`](https://github.com/JakeChampion/fetch/issues/569) - Match spec behavior re: unsupported body type [`elastic#576`](https://github.com/JakeChampion/fetch/issues/576) - Run test files through prettier [`0a57487`](https://github.com/JakeChampion/fetch/commit/0a5748775d99f882172375693f56761383f8faf3) - Unwrap `fetch.js` to be a clean module file [`8aec47c`](https://github.com/JakeChampion/fetch/commit/8aec47cb6c67a9a321f1eb07457f70fc46235610) - Switch from PhantomJS to Karma + Chrome/Firefox for testing [`b539589`](https://github.com/JakeChampion/fetch/commit/b53958904649bfeb784083b9b7e0b89902c7d30e) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM5LjEwNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJUZWFtOk9wZXJhdGlvbnMiLCJiYWNrcG9ydDphbGwtb3BlbiIsInJlbGVhc2Vfbm90ZTpza2lwIl19--> Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com> Co-authored-by: Brad White <[email protected]>
thomheymann
pushed a commit
that referenced
this pull request
Oct 18, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [rison-node](https://github.com/w33ble/rison-node) | dependencies | major | [`1.0.2` -> `2.1.1`](https://renovatebot.com/diffs/npm/rison-node/1.0.2/2.1.1) | --- ### Release Notes <details> <summary>w33ble/rison-node (rison-node)</summary> ### [`v2.1.1`](https://github.com/w33ble/rison-node/blob/HEAD/CHANGELOG.md#v211-4-June-2020) [Compare Source](https://github.com/w33ble/rison-node/compare/v2.1.0...v2.1.1) - fix: handle keys that start with numbers [`f0e10e3`](https://github.com/w33ble/rison-node/commit/f0e10e377bc328bfeb82e74c6498394612e6e4e6) ### [`v2.1.0`](https://github.com/w33ble/rison-node/blob/HEAD/CHANGELOG.md#v210-1-November-2018) [Compare Source](https://github.com/w33ble/rison-node/compare/v2.0.0...v2.1.0) - feat: add decode_uri method [`#2`](https://github.com/w33ble/rison-node/pull/2) - feat: add rison.unquote, use in decode_uri [`41ba487`](https://github.com/w33ble/rison-node/commit/41ba487d05ba623ce8bcde5da96517df61e2e7ff) - v2.1.0 [`71c9910`](https://github.com/w33ble/rison-node/commit/71c991021497c9ad229b289b6a4bd72672855c50) ### [`v2.0.0`](https://github.com/w33ble/rison-node/blob/HEAD/CHANGELOG.md#v200-30-April-2018) [Compare Source](https://github.com/w33ble/rison-node/compare/v1.0.2...v2.0.0) - v2.0.0 [`409eede`](https://github.com/w33ble/rison-node/commit/409eedecda2ced49f31c57bfe250ddefd24b5cfe) - **Breaking:** feat: prevent quoting numeric keys [`01e2be2`](https://github.com/w33ble/rison-node/commit/01e2be2fb546fdeea9f68cd5fd9087660cc1802c) ##### [v1.0.2](https://github.com/w33ble/rison-node/compare/v1.0.1...v1.0.2) (17 April 2018) - docs: proper fork, update repo, add badges [`667fc6c`](https://github.com/w33ble/rison-node/commit/667fc6cd6a3ef4022228dd5de6f1d8a28b153eba) - 1.0.2 [`41f1f52`](https://github.com/w33ble/rison-node/commit/41f1f528c4102553fa55d3a7ee54ba5b1f312eeb) ##### [v1.0.1](https://github.com/w33ble/rison-node/compare/v1.0.0...v1.0.1) (17 April 2018) - 1.0.1 [`df44524`](https://github.com/w33ble/rison-node/commit/df44524cc91690a4f1bd425ae434c6cc7e3fb6e0) - docs: update readme [`09bbabf`](https://github.com/w33ble/rison-node/commit/09bbabf3959d77bf26caa84f7221b3625992d27c) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMDcuMCIsInVwZGF0ZWRJblZlciI6IjM5LjEwNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJUZWFtOlNoYXJlZFVYIiwiYmFja3BvcnQ6YWxsLW9wZW4iLCJyZWxlYXNlX25vdGU6c2tpcCJdfQ==--> --------- Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com> Co-authored-by: Tim Sullivan <[email protected]> Co-authored-by: Timothy Sullivan <[email protected]> Co-authored-by: Krzysztof Kowalczyk <[email protected]>
thomheymann
pushed a commit
that referenced
this pull request
Oct 18, 2025
…gent is lost (elastic#237705) ## Summary Since we use spot agents for our FTR tests, there are cases that some of the configs are already run but due to agent lost, we will try all the config of that group again. In this PR, we use Buildkite metadata config to keep track of configs that are already executed, so that if the agent is lost, we first check if there is a metadata for this config, if yes, we will skip running that config. For this logic to work, we also need to save the Scout events related to each config after running each config instead of at the end of each config group, to ensure if the agent is lost, we will keep the related execution stats and events. #### Expected improvement |Build|Before|After|Improvement| |---|---|---|---| |[348415](https://buildkite.com/elastic/kibana-pull-request/builds/348415)|2h 25m (estimate)|1h 37m|saves 48 minutes (~33% faster)| |[348229](https://buildkite.com/elastic/kibana-pull-request/builds/348229)|1h 39m|1h 10m (estimate)|saves 29 minutes (~30% faster)| |[348223](https://buildkite.com/elastic/kibana-pull-request/builds/348223/waterfall)|2h 3m|1h 17m (estimate)| saves 46 minutes (~37% faster)| In the last [example](https://buildkite.com/elastic/kibana-pull-request/builds/348223/waterfall), `FTR Configs #2` takes almost double the time because the agent is lost when executing the last config. <img width="2588" height="456" alt="image" src="https://github.com/user-attachments/assets/992ffc6b-4412-47f9-9dd2-ecd5ff607358" /> Here is a video that illustrates the issue for this [build](https://buildkite.com/elastic/kibana-pull-request/builds/348229): https://github.com/user-attachments/assets/5f499f78-5841-40e7-8582-e761b885ed41 ### 🧪 How to test What I did was run a small portion of the tests in this [build](https://buildkite.com/elastic/kibana-pull-request/builds/348316), wait for one config to finish and report its stats, then cancel the build and retry it to see if the new build would skip the completed config as expected. In this [build](https://buildkite.com/elastic/kibana-pull-request/builds/348415), it also improved `FTR Config 6`, although the previous failure was "Exited with status 10" not agent loss. - **Before**: 2h 25m (estimate) - **After**: 1h 37m - **Time saved**: 48 minutes (~33% faster) <img width="2934" height="146" alt="image" src="https://github.com/user-attachments/assets/88b7ad5a-46b1-42ad-9321-f33a81d89ee6" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.