Fix: Notifier should fire during runtime, even if DisableNotifierOnInit is true (#2569)

8ma10s · thomaspoignant · web-flow · commit 1f5b7925eac2 · 2024-10-25T09:04:18.000+02:00
Co-authored-by: Thomas Poignant &lt;thomas.poignant@gofeatureflag.org&gt;
diff --git a/feature_flag.go b/feature_flag.go
@@ -279,7 +279,7 @@ func retrieveFlagsAndUpdateCache(config Config, cache cache.Manager,
 		return err
 	}
 
-	err = cache.UpdateCache(newFlags, config.internalLogger, isInit && !config.DisableNotifierOnInit)
+	err = cache.UpdateCache(newFlags, config.internalLogger, !(isInit && config.DisableNotifierOnInit))
 	if err != nil {
 		log.Printf("error: impossible to update the cache of the flags: %v", err)
 		return err

Original file line number	Diff line number	Diff line change
`@@ -279,7 +279,7 @@ func retrieveFlagsAndUpdateCache(config Config, cache cache.Manager,`
`279`	`279`	`return err`
`280`	`280`	`}`
`281`	`281`
`282`		`- err = cache.UpdateCache(newFlags, config.internalLogger, isInit && !config.DisableNotifierOnInit)`
	`282`	`+ err = cache.UpdateCache(newFlags, config.internalLogger, !(isInit && config.DisableNotifierOnInit))`
`283`	`283`	`if err != nil {`
`284`	`284`	`log.Printf("error: impossible to update the cache of the flags: %v", err)`
`285`	`285`	`return err`