From 78173c8a5f2c3ec6ac56bcc280b5d06a1912d1b2 Mon Sep 17 00:00:00 2001 From: Thomas Luizon Rodrigues Gregorio Date: Fri, 31 Jul 2026 00:23:29 -0300 Subject: [PATCH] ORB-164: name the harness dimension as the rubric twins' UI-only divergence The orbit-ui-mobile test-file split (ORB-163 section C2) moves every decision-path case body out of tools/test-tools.mjs and into one module per tool under tools/__tests__/, and rewrites dimension 15 of the orbit-ui-mobile rubric to point at that layout. Dimension 15 has no counterpart here, so the split forces no dimension edit in this copy. What it does force is an honest description of the divergence, because this file currently claims the sanctioned differences are "backend-only material", and the largest one runs the other way: dimension 15 is orbit-ui-mobile-only, and it is the exact hunk whose declared fingerprint the paired pull request recomputes. The paragraph now names both directions and says why the harness dimension cannot exist here: neither the runner nor the tools/__tests__/ case modules are checked out in this repository, so a reviewer here has no Harness Execution job to cite. Verified, not assumed: node tools/check-lockstep.mjs run from the orbit-ui-mobile worktree with --api-root pointed at this one exits 0 with "HARNESS LOCKSTEP OK: 6 pairs checked" after the paired fingerprint update, with the exit code read from a file rather than through a pipe. Repo-tool appeal: the lockstep checker's invocation and its exit code are the evidence this commit claims, so naming them is the record. Co-Authored-By: Claude Opus 5 (1M context) Claude-Session: https://claude.ai/code/session_01Bojq5cLFZ87iBD8zhnoSWH --- .claude/skills/pr-review/rubric.md | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.claude/skills/pr-review/rubric.md b/.claude/skills/pr-review/rubric.md index fd28ad99..227f2527 100644 --- a/.claude/skills/pr-review/rubric.md +++ b/.claude/skills/pr-review/rubric.md @@ -10,9 +10,13 @@ rubric over the whole repo. **A second copy exists**, at `orbit-ui-mobile/.claude/skills/pr-review/rubric.md`, where `/audit-code-quality` also walks it. Two repos and two CIs mean the file cannot be deduped, so the copies are lockstep twins kept aligned by hand, exactly like the two -`pr-review/SKILL.md` copies. Sanctioned divergences are backend-only material, such as -dimension 13's transaction-teardown bullet (`ORBIT0002`). Change a dimension here and -mirror it there in the same task; a drift between the two is a defect, not a variant. +`pr-review/SKILL.md` copies. Sanctioned divergences run in both directions: backend-only +material here, such as dimension 13's transaction-teardown bullet (`ORBIT0002`), and +orbit-ui-mobile-only material there, such as dimension 15's harness-execution evidence, +which has no counterpart in this repository because the harness runner +`tools/test-tools.mjs` and the per-tool case modules it loads from `tools/__tests__/` exist +only in orbit-ui-mobile. Change a dimension here and mirror it there in the same task; a +drift between the two is a defect, not a variant. It is command-agnostic on purpose: it contains **dimensions, severities, and templates**, no orchestration, no scope resolution, no GitHub mechanics. Those live in the consuming