Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option of excluding lineBreakChar for final property of object #52

Open
Benelio opened this issue Feb 27, 2020 · 3 comments
Open

Option of excluding lineBreakChar for final property of object #52

Benelio opened this issue Feb 27, 2020 · 3 comments

Comments

@Benelio
Copy link

Benelio commented Feb 27, 2020

When logging on a single line, the lineBreakChar can currently be set to ',' (for example) to comma separate the properties of the object. However, the final property will then still print the lineBreakChar at the end, which looks incorrect.

e.g.

property1 = "a" , property2 = "b" , property3 = "c" ,

It would be a nice feature to have an option of excluding this linebreakChar for the final property. Which I suppose people might still want even if using newline as the character.

@thomasgalliker
Copy link
Owner

Ok, I see. It looks like we’re line-breaking at the end of each property, regardless of which lineBreakChar is configured.

I gonna look into this as soon as I have some spare time. (Is it critical? I guess its just a code style issue for you?)

@thomasgalliker
Copy link
Owner

thomasgalliker commented Aug 22, 2020

I tried to reproduce this issue but I can't. Can you write a unit test which reproduces the error case? You can also just post the repro code here, @Benelio

@thomasgalliker
Copy link
Owner

@Benelio is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants