Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: does nothing on MacOS #1

Closed
Jackymancs4 opened this issue Jul 10, 2019 · 1 comment
Closed

Bug: does nothing on MacOS #1

Jackymancs4 opened this issue Jul 10, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@Jackymancs4
Copy link

Hello @thomascsd
As the title says, the extension does nothing on MacOS 10.14.5 and VSCode 1.36.1.

My idea is that in both

const filePath = `${url.fsPath}\\README.md`;

and

const pkgUrl = `${url.fsPath}\\package.json`;

you used path\\file which works on Windows (resulting in something like path\to\my\file, but on both Mac and Linux it results in path\to\my/file, as confirmed by the Developer Console.

I have not tested the fix, but I think using path.join() instead of string concatenation should work.
Thanks

@thomascsd thomascsd added the bug Something isn't working label Jul 11, 2019
@thomascsd
Copy link
Owner

I'll fix it soon
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants