Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: pre-run/post-run options #6

Open
githubjsorg opened this issue Oct 29, 2019 · 3 comments
Open

Feature Request: pre-run/post-run options #6

githubjsorg opened this issue Oct 29, 2019 · 3 comments

Comments

@githubjsorg
Copy link

githubjsorg commented Oct 29, 2019

Hi. I haven't used this or the related rsync-time-backup tools yet but am planning on doing so.

A feature that would be extremely useful in this wrapper is pre/post-backup/restore commands similar to pre/post-up/down options in debian /etc/network/interfaces config.

Ex.
PRE_BACKUP=SOME COMMAND
POST_BACKUP=SOME OTHER COMMAND

Example Use Case:
Make sure a Databases files are synced to disk before backup. Either by shutting the DB down PRE_RUN and starting it back up POST_RUN. Or using lock/unlock commands pre/post run, etc.
Or alternatively do a dump so that also gets backed up.

@githubjsorg githubjsorg changed the title Feature Request: pre-run/post-run Feature Request: pre-run/post-run options Oct 29, 2019
@thomas-mc-work
Copy link
Owner

Thank's for reporting, @githubjsorg!

Actually I like the idea. But there are two things in my mind about that.

  1. I tend to remove the config.inc file and only invoke rsync and rsync_tmbackup.sh, trusting they are both in the $PATH. If not there will be an env variable to override their paths. Thus, this tool would remove support of tooling integration and let this leave to the user. Finally, it'd be required to wrap the invocation if special needs are required (like adjusting the process priority or invoke pre/post commands).
  2. I'm already working on a successor to this tool which already has support for this.

But I'll think about it anyway and maybe just integrate it.

@githubjsorg
Copy link
Author

"I'm already working on a successor to this tool which already has support for this."

Nice. What is the name of this and do you have an ETA for it?

As for the pre/post run stuff, for my current project, I have been just wrapping rsync_tmbackup in another SSH script for each backup job. Not as elegant but does the job.

@thomas-mc-work
Copy link
Owner

There is no name nor ETA yet. But I'll announce any news on that project in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants