Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[angular-ngrx-scss]: load readme relative to path, link to readme #1961

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[angular-ngrx-scss]: load readme relative to path, link to readme #1961

wants to merge 1 commit into from

Conversation

honzikec
Copy link
Contributor

Summary of change

  • The root README only shows on the root page - if navigating into other folders, the root README does not show on those pages
  • If a deeper folder has it's own README file, that file shows
  • Clicking the Readme link in the about section of the page scrolls down to the readme section

Checklist

@honzikec honzikec requested a review from Megio August 29, 2023 12:41
@honzikec honzikec self-assigned this Aug 29, 2023
@honzikec honzikec force-pushed the angular-ngrx-scss/readme-issues branch 2 times, most recently from 994c446 to 2b2ae1b Compare August 29, 2023 14:54
@honzikec honzikec force-pushed the angular-ngrx-scss/prs branch 2 times, most recently from d3354c3 to cfee37f Compare August 29, 2023 16:02
Base automatically changed from angular-ngrx-scss/prs to main August 30, 2023 12:33
@honzikec honzikec force-pushed the angular-ngrx-scss/readme-issues branch from 2b2ae1b to 966f4f1 Compare August 30, 2023 12:37
@netlify
Copy link

netlify bot commented Aug 30, 2023 •
edited
Loading

✅ Deploy Preview for angular-apollo-tailwind canceled.

Name Link
🔨 Latest commit 966f4f1
🔍 Latest deploy log https://app.netlify.com/sites/angular-apollo-tailwind/deploys/64ef7f2336299e00081b26a4

@netlify
Copy link

netlify bot commented Aug 30, 2023 •
edited
Loading

✅ Deploy Preview for cra-rxjs-styled-components canceled.

Name Link
🔨 Latest commit 966f4f1
🔍 Latest deploy log https://app.netlify.com/sites/cra-rxjs-styled-components/deploys/64ef7f23720e4300089f14ee

@netlify
Copy link

netlify bot commented Aug 30, 2023 •
edited
Loading

✅ Deploy Preview for angular-ngrx-scss ready!

Name Link
🔨 Latest commit 966f4f1
🔍 Latest deploy log https://app.netlify.com/sites/angular-ngrx-scss/deploys/64ef7f23e425a50008342af2
😎 Deploy Preview https://deploy-preview-1961--angular-ngrx-scss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 30, 2023 •
edited
Loading

✅ Deploy Preview for solidjs-tailwind canceled.

Name Link
🔨 Latest commit 966f4f1
🔍 Latest deploy log https://app.netlify.com/sites/solidjs-tailwind/deploys/64ef7f2336299e00081b26a9

@netlify
Copy link

netlify bot commented Aug 30, 2023 •
edited
Loading

✅ Deploy Preview for vue3-apollo-quasar canceled.

Name Link
🔨 Latest commit 966f4f1
🔍 Latest deploy log https://app.netlify.com/sites/vue3-apollo-quasar/deploys/64ef7f23d107590008f5abec

@netlify
Copy link

netlify bot commented Aug 30, 2023 •
edited
Loading

✅ Deploy Preview for nuxt-pinia-tailwind canceled.

Name Link
🔨 Latest commit 966f4f1
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-pinia-tailwind/deploys/64ef7f239d2023000885b64c

@netlify
Copy link

netlify bot commented Aug 30, 2023 •
edited
Loading

✅ Deploy Preview for next-react-query-tailwind canceled.

Name Link
🔨 Latest commit 966f4f1
🔍 Latest deploy log https://app.netlify.com/sites/next-react-query-tailwind/deploys/64ef7f2335877f00071c2df6

@netlify
Copy link

netlify bot commented Aug 30, 2023 •
edited
Loading

✅ Deploy Preview for svelte-kit-scss canceled.

Name Link
🔨 Latest commit 966f4f1
🔍 Latest deploy log https://app.netlify.com/sites/svelte-kit-scss/deploys/64ef7f23719a5c00082a060a

@netlify
Copy link

netlify bot commented Aug 30, 2023 •
edited
Loading

✅ Deploy Preview for starter-dev-backend canceled.

Name Link
🔨 Latest commit 966f4f1
🔍 Latest deploy log https://app.netlify.com/sites/starter-dev-backend/deploys/64ef7f241e4a220008bbe243

@netlify
Copy link

netlify bot commented Aug 30, 2023 •
edited
Loading

✅ Deploy Preview for solidstart-tanstackquery-tailwind-mod canceled.

Name Link
🔨 Latest commit 966f4f1
🔍 Latest deploy log https://app.netlify.com/sites/solidstart-tanstackquery-tailwind-mod/deploys/64ef7f23e8319600077736ae

@netlify
Copy link

netlify bot commented Aug 30, 2023 •
edited
Loading

✅ Deploy Preview for remix-gql-tailwind canceled.

Name Link
🔨 Latest commit 966f4f1
🔍 Latest deploy log https://app.netlify.com/sites/remix-gql-tailwind/deploys/64ef7f23caa89b000844d500

@netlify
Copy link

netlify bot commented Aug 30, 2023 •
edited
Loading

✅ Deploy Preview for expo-zustand-styled-components canceled.

Name Link
🔨 Latest commit 966f4f1
🔍 Latest deploy log https://app.netlify.com/sites/expo-zustand-styled-components/deploys/64ef7f2395305c0008c4ac5b

@netlify
Copy link

netlify bot commented Aug 30, 2023 •
edited
Loading

✅ Deploy Preview for qwik-graphql-tailwind canceled.

Name Link
🔨 Latest commit 966f4f1
🔍 Latest deploy log https://app.netlify.com/sites/qwik-graphql-tailwind/deploys/64ef7f23d209a20008d20d99

@honzikec honzikec marked this pull request as ready for review August 30, 2023 12:40
@honzikec honzikec force-pushed the angular-ngrx-scss/readme-issues branch from 9024a4f to 966f4f1 Compare August 30, 2023 17:01
@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Megio Megio Awaiting requested review from Megio

At least 1 approving review is required to merge this pull request.

Assignees

@honzikec honzikec

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Angular - NgRx - SCSS] Single repo README issues
1 participant
@honzikec