Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow-clj is watching folders from GitHub dependecies? #1013

Closed
enesj opened this issue May 19, 2022 · 2 comments
Closed

Shadow-clj is watching folders from GitHub dependecies? #1013

enesj opened this issue May 19, 2022 · 2 comments

Comments

@enesj
Copy link

enesj commented May 19, 2022

watch-loop function In namespace shadow.cljs.devtools.server.fs-watch accepts the watch-dirs parameter. IMO this parameter defines all folders that shadow-clj wtaches for changes.

Problem is that in my case watch-dirs contains entries like this one:
":dir" -> {File@30133} "/Users/enesjakic/.gitlibs/libs/com.flexiana/framework/b2d003c5447f6b6dd94e0629f03f2228089a9363/src"
which is the GitHub dependency from deps.edn and it don't need to be watched I think.

Is this the bug or an intentional decision?

@thheller
Copy link
Owner

They don't change so watching them is not that big of a deal. Also unnecessary though, so I removed it.

@enesj
Copy link
Author

enesj commented May 19, 2022

Thanks. It was really fast. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants