add timeout on docker username #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
closes #1184 |
riyazdf
reviewed
Jul 24, 2017
There was a problem hiding this comment.
works locally, just would be great to get a more verbose log since the 401 error isn't very helpful:
🐳 $ bin/notary -s https://notary.docker.io list docker.io/some/repo
Enter username:
* fatal: you are not authorized to perform this operation: server returned 401.
cmd/notary/tuf.go
Outdated
| return "","" | ||
| } | ||
| case <-time.After(30 * time.Second): | ||
| return "","" |
There was a problem hiding this comment.
can we add an error log here? Something like timeout when retrieving username input?
riyazdf
approved these changes
Jul 24, 2017
cmd/notary/tuf.go
Outdated
| return "","" | ||
| } | ||
| case <-time.After(30 * time.Second): | ||
| logrus.Errorf("timeout when retrieving username input") |
There was a problem hiding this comment.
nit: this can just be logrus.Error (no need for formatting)
Signed-off-by: Kyle Spiers <[email protected]> add additional error logging Signed-off-by: Kyle Spiers <[email protected]>
endophage
approved these changes
Jul 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix scripts that never end due to a user/pass prompt.
Signed-off-by: Kyle Spiers [email protected]