Auto-parse the DB URL and add parseTime=true if the backend is mysql #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyli
reviewed
May 8, 2017
utils/configuration.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if !url_config.ParseTime { |
There was a problem hiding this comment.
Non-blocking: We can probably just set url_config.ParseTime to true here, since if it was true before, setting it to true again doesn't hurt anything. :)
Would be awesome if we could add a test for this though!
Also updates the mysql driver to a newer release Signed-off-by: Ashwini Oruganti <[email protected]>
Signed-off-by: Ashwini Oruganti <[email protected]>
truie either way without any issues Signed-off-by: Ashwini Oruganti <[email protected]>
Signed-off-by: Ashwini Oruganti <[email protected]>
Signed-off-by: Ashwini Oruganti <[email protected]>
Signed-off-by: Ashwini Oruganti <[email protected]>
|
Re-iterating @cyli, we need to add a test :-) |
Signed-off-by: Ashwini Oruganti <[email protected]>
endophage
approved these changes
May 9, 2017
|
LGTM! Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #328
Also updates the mysql driver to a newer release
Signed-off-by: Ashwini Oruganti [email protected]