Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][LNL] [SDW] audio glitches on LNL-SDW #8809

Open
keqiaozhang opened this issue Jan 29, 2024 · 20 comments
Open

[BUG][LNL] [SDW] audio glitches on LNL-SDW #8809

keqiaozhang opened this issue Jan 29, 2024 · 20 comments
Labels
bug Something isn't working as expected LNL Applies to Lunar Lake platform P2 Critical bugs or normal features SDW SoundWire
Milestone

Comments

@keqiaozhang
Copy link
Collaborator

keqiaozhang commented Jan 29, 2024

Describe the bug
The JD issue has been fixed on LNL-SDW platforms, so now we are able to check the audio quality on LNL-SDW.
Now I observed the audio glitches on both playback and capture, but the reproduction rate is low, not easy to reproduce manually.
Here are the failures we captured in CI daily test.

On playback:
image
There're a lot of xrun warning during the test.

2024-01-28 22:11:39 UTC [REMOTE_INFO] Starting /usr/local/bin/mtrace-reader.py >& /home/ubuntu/sof-test/logs/check-alsabat/2024-01-28-22:11:38-10012/mtrace.txt &
2024-01-28 22:11:39 UTC [REMOTE_INFO] check the PCMs before alsabat test
2024-01-28 22:11:41 UTC [REMOTE_COMMAND] alsabat -Phw:sofsoundwire,0 --standalone -n 240000 -r 48000 -c 2 -f S16_LE -F 821 -k 2.1
2024-01-28 22:11:42 UTC [REMOTE_COMMAND] alsabat -Chw:CODEC,0 -c 2 -r 48000 -f S16_LE -F 821 -k 2.1
Underrun: Broken pipe(-32)
Underrun: Broken pipe(-32)
Underrun: Broken pipe(-32)
Underrun: Broken pipe(-32)
Underrun: Broken pipe(-32)
Underrun: Broken pipe(-32)
Underrun: Broken pipe(-32)
Underrun: Broken pipe(-32)
Underrun: Broken pipe(-32)
Underrun: Broken pipe(-32)
Underrun: Broken pipe(-32)
Underrun: Broken pipe(-32)
Underrun: Broken pipe(-32)
Underrun: Broken pipe(-32)

On capture:
image

To Reproduce

Playback test:~/sof-test/test-case/check-alsabat.sh -p hw:sofsoundwire,0 -c hw:CODEC,0 -C 2 -F 821

Capture test:~/sof-test/test-case/check-alsabat.sh -c hw:sofsoundwire,1 -p hw:CODEC,0 -C 2 -F 821

Reproduction Rate
Low, less than 10%.

Environment

  1. Branch name and commit hash of the 2 repositories: sof (firmware/topology) and linux (kernel driver).
  2. Name of the topology file
    • Topology: {sof-lnl-rt711-l0-rt1316-l23-rt714-l1.tplg}
  3. Name of the platform(s) on which the bug is observed.
    • Platform: {LNL-SDW w/ Gen4.1 AIOC base board}

wav-file.gz

cc:

@keqiaozhang keqiaozhang added bug Something isn't working as expected SDW SoundWire LNL Applies to Lunar Lake platform labels Jan 29, 2024
@keqiaozhang keqiaozhang changed the title [BUG]audio glitches on LNL-SDW [BUG][LNL] [SDW] audio glitches on LNL-SDW Jan 29, 2024
@plbossart
Copy link
Member

probably the same as thesofproject/linux#4754, it's not worth investigating audio quality issues until fw-based aggregation is merged in firmware and kernel

@lgirdwood lgirdwood added this to the v2.10 milestone Jan 31, 2024
@lgirdwood
Copy link
Member

probably the same as thesofproject/linux#4754, it's not worth investigating audio quality issues until fw-based aggregation is merged in firmware and kernel

Ok, lets wait until aggregation is fully ready. I've put in v2.10 for the moment, can be moved to v2.9 if needed.

@lgirdwood
Copy link
Member

@plbossart @bardliao @ujfalusi whats the status today ?

@plbossart
Copy link
Member

I don't think we can reach any conclusions, we still have FAILs in alsa-bat, and I don't get if this is still related to the jack setup or now.

@bardliao
Copy link
Collaborator

@plbossart @lgirdwood I checked some recent daily test results, check-alsabat-headset-playback seems pass consistently and some of the check-alsabat-headset-capture are failed. But they are all because of the signal is too low not like this issue's description.
And the issue is tracking at thesofproject/linux#5076.

But the reproduction rate of this issue is low. So, I don't know if it is fixed or just not reproduced recently.

@lgirdwood
Copy link
Member

@fredoh9 @marc-hb @ssavati anyone seen this on daily test recently ? If not we can close. This is different from the bank switch and missing IRQ.

@plbossart
Copy link
Member

we are not even looking at quality issues for now, the priority is to deal with timeouts.

@marc-hb
Copy link
Collaborator

marc-hb commented Jun 10, 2024

I've seen this "Underrun: Broken pipe" recently. Also, alsabat (which is the only "real" audio test in sof-test) is still failing left and right on LNL.

@marc-hb
Copy link
Collaborator

marc-hb commented Jun 13, 2024

I've seen this "Underrun: Broken pipe" recently.

One just now:

@plbossart
Copy link
Member

One just now:

Different issue. We're tracking SoundWire issues here, the HDA alsabat stuff is a different problem relying on a different topology and a different physical interface/timing.

@marc-hb
Copy link
Collaborator

marc-hb commented Jun 18, 2024

Sorry my bad, went too fast. To make amend, here's the SDW, "signal too weak" failure of the day:

https://sof-ci.01.org/softestpr/PR931/build518/devicetest/index.html?model=LNLM_SDW_AIOC&testcase=check-alsabat-headset-capture-599

@marc-hb
Copy link
Collaborator

marc-hb commented Jun 18, 2024

... and still wrong, there is yet another issue about that: thesofproject/linux#5076. Really sorry, I'm losing track

@kv2019i kv2019i added the P1 Blocker bugs or important features label Jun 25, 2024
@kv2019i
Copy link
Collaborator

kv2019i commented Jun 28, 2024

Reproduction rate low in past week, continue with P2 and assign to v2.11.

@kv2019i kv2019i added P2 Critical bugs or normal features and removed P1 Blocker bugs or important features production blocker labels Jun 28, 2024
@kv2019i kv2019i modified the milestones: v2.10, v2.11 Jun 28, 2024
@kv2019i
Copy link
Collaborator

kv2019i commented Sep 9, 2024

Reviewing a week worth of daily test plans with this configurations (starting 2024-09-02), this test is passing all the time. It is likely zephyrproject-rtos/zephyr#77805 fix was responsible for the occasional 1ms glitches seen in this test and those are now gone.

@kv2019i kv2019i closed this as completed Sep 9, 2024
@kv2019i
Copy link
Collaborator

kv2019i commented Sep 10, 2024

Murphy's law, the next daily plan shows a fail again, 2024-09-09 run has a fail. Console has a overrun and the captured bat.wav look like this:

image

... rest of file is clean. Reopening.

@kv2019i kv2019i reopened this Sep 10, 2024
@kv2019i kv2019i modified the milestones: v2.11, v2.12 Sep 13, 2024
@lrudyX
Copy link

lrudyX commented Sep 13, 2024

@kv2019i please create new ticket for this problem

@marc-hb
Copy link
Collaborator

marc-hb commented Sep 13, 2024

@lrudyX can you summarize how it is a different issue now?

@kv2019i
Copy link
Collaborator

kv2019i commented Sep 13, 2024

@lrudyX I think this is exactly the original problem (quoting the original bug report from January):

2024-01-28 22:11:39 UTC [REMOTE_INFO] Starting /usr/local/bin/mtrace-reader.py >& /home/ubuntu/sof-test/logs/check-alsabat/2024-01-28-22:11:38-10012/mtrace.txt &
2024-01-28 22:11:39 UTC [REMOTE_INFO] check the PCMs before alsabat test
2024-01-28 22:11:41 UTC [REMOTE_COMMAND] alsabat -Phw:sofsoundwire,0 --standalone -n 240000 -r 48000 -c 2 -f S16_LE -F 821 -k 2.1
2024-01-28 22:11:42 UTC [REMOTE_COMMAND] alsabat -Chw:CODEC,0 -c 2 -r 48000 -f S16_LE -F 821 -k 2.1
Underrun: Broken pipe(-32)
Underrun: Broken pipe(-32)
Underrun: Broken pipe(-32)
Underrun: Broken pipe(-32)

We still see the underruns on certain DUT configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected LNL Applies to Lunar Lake platform P2 Critical bugs or normal features SDW SoundWire
Projects
None yet
Development

No branches or pull requests

8 participants