Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTEL] Remove support for INFO_PAUSE #1339

Closed
plbossart opened this issue Oct 18, 2019 · 2 comments
Closed

[INTEL] Remove support for INFO_PAUSE #1339

plbossart opened this issue Oct 18, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@plbossart
Copy link
Member

Tracking this topic as an 'enhancement'

#1336 introduces platform-specific INFO flags
The next logical steps is to revisit support for INFO_PAUSE.

Facts:

  1. PulseAudio and CRAS do not use PAUSE_PUSH/PAUSE_RELEASE
  2. The implicit assumption is that on PAUSE_RELEASE playback should restart from the exact position reached when PAUSE_PUSH was signaled. None of the Intel platforms can guarantee such a level of accuracy.
  3. In addition, ALSA generates nasty warnings when doing a PAUSE_RELEASE after a suspend-release transition (when INFO_RESUME is not supported as well)

So is it time to remove INFO_PAUSE? Does anyone have an objection or counter-argument?

@plbossart plbossart added the enhancement New feature or request label Oct 18, 2019
@plbossart
Copy link
Member Author

I am told Windows does require support for pause. If we truly want to support this, we should probably have a context save/restore as done for closed-source firmware. Just doing a stop/start is probably not so good.
@lbetlej @mmaka1 if we really want to support pause there are probably more hooks to be added for firmware?

@plbossart
Copy link
Member Author

no plans to remove PAUSE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant