Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Document tabby_config.yml in wiki #241

Open
3 tasks done
Originalimoc opened this issue Nov 15, 2024 · 0 comments
Open
3 tasks done

[REQUEST] Document tabby_config.yml in wiki #241

Originalimoc opened this issue Nov 15, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@Originalimoc
Copy link

Originalimoc commented Nov 15, 2024

Problem

This is basically a "hidden" feature which is very useful.

Solution

Document it in Wiki - Per model config or Model specific config. Also the "inline_model_loading" is also missing doc but it's self-explanatory.

Additional context

Currently because of "merged_kwargs = {**override_args, **kwargs}" not "merged_kwargs = {**kwargs, **override_args}", config.yml will override tabby_config.yml On First Load(API request "Inline load" will always prefer tabby_config.yml), so you need to keep config.yml blank to avoid confusion. Is this intended behaviour? With presence of "use_as_default" this get even more confusing. Is there a better/cleaner/nicer, more restrictive but no ambiguity way? /First step at least use latter merged_kwargs= to make load behavior consistent.

Acknowledgements

  • I have looked for similar requests before submitting this one.
  • I understand that the developers have lives and my issue will be answered when possible.
  • I understand the developers of this program are human, and I will make my requests politely.
@bdashore3 bdashore3 added the documentation Improvements or additions to documentation label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants