Skip to content

Conversation

@kiwik
Copy link
Contributor

@kiwik kiwik commented Jun 28, 2019

Make all of OpenLab jobs to use new role "install-docker" to
install and config docker-ce, update tags of related jobs
to specific docker version and remove all of "latest-release" define.

Closes: theopenlab/openlab#308

Make all of OpenLab jobs to use new role "install-docker" to
install and config docker-ce, update tags of related jobs
to specific docker version and remove all of "latest-release" define.

Closes: theopenlab/openlab#308
@kiwik kiwik requested review from huangtianhua and liusheng June 28, 2019 02:45
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 28, 2019

Build succeeded.

Copy link
Contributor

@liusheng liusheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ZhengZhenyu
Copy link
Contributor

why not get rid of install-docker-ce role in this patch directly?

@kiwik
Copy link
Contributor Author

kiwik commented Jun 28, 2019

@ZhengZhenyu will remove role install-docker-ce when all of related job builds are OK

@ZhengZhenyu ZhengZhenyu merged commit 9b1d078 into master Jun 28, 2019
@huangtianhua huangtianhua deleted the apply-docker-role branch June 28, 2019 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply role install-docker-ce for all of OpenLab jobs

5 participants