Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ElasticSearch v7 #127

Open
jmariller opened this issue May 23, 2024 · 2 comments
Open

Support for ElasticSearch v7 #127

jmariller opened this issue May 23, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@jmariller
Copy link

Hi,

First of all thanks a lot for this library.

In the project I am working on we are using jolicode/elastically, which is indirectly (via ruflin/elastica) based on version 7 of elasticsearch/elasticsearch.

Now I would like to use ElasticsearchVectorStore, however I am not able to pass the proper ElasticSearch client as the namespace changed from v7 to v8.

Is there any way that the LLPhant could support ElasticSearch v7 as well?

Cheers

@MaximeThoonsen
Copy link
Collaborator

Hey @jmariller,

Sure I will add it as a feature request. Is this something that you would want to contribute?

@MaximeThoonsen MaximeThoonsen added the enhancement New feature or request label May 31, 2024
@jmariller
Copy link
Author

Hi @MaximeThoonsen thank you for your answer! I would be happy to help, however in the meantime I noticed that there were changes in the namespaces of Elastisearch between v7 and v8, making such a feature pretty tricky - I am wondering if it is even possible? So I am currently rather trying to help the maintainers of jolicode to have their elastically library migrate to v8. So I guess we can put this issue on hold for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants