Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hyphen instead of en dash #907

Merged
merged 8 commits into from
Jun 24, 2019
Merged

Use hyphen instead of en dash #907

merged 8 commits into from
Jun 24, 2019

Conversation

stevenjoezhang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: #899

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

1v9
1v9 previously approved these changes Jun 9, 2019
@1v9 1v9 changed the title Use endash instead of hyphen Use en dash instead of hyphen Jun 9, 2019
@1v9 1v9 self-requested a review June 9, 2019 05:30
@1v9 1v9 dismissed their stale review June 9, 2019 05:30

confusing

@1v9
Copy link
Member

1v9 commented Jun 9, 2019

Which one is longer?
HYPHEN (-) vs. EN DASH (–)

@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Jun 9, 2019

https://cherysunzhang.com/2016/08/using-hyphen-and-dash-correctly/

Cherysun’s Tech Café
在书写和排版英文文本的时候,会遇到用于表示连接的一些标点符号,经常使用并且被很多人使用错误的就是 hyphen、en dash 和 em dash 了。下面就将简明地介绍如何正确地使用这些标点符号以及如何在键盘上正确地输入它们。

@Raincal
Copy link
Member

Raincal commented Jun 9, 2019

只有 subtitle 那里需要改,其它地方不变

LICENSE.md Outdated Show resolved Hide resolved
@1v9
Copy link
Member

1v9 commented Jun 9, 2019

In fact I am a little dizzy, if I'm wrong please tell me.

@stevenjoezhang
Copy link
Contributor Author

@Raincal 应保持统一。

@Raincal
Copy link
Member

Raincal commented Jun 9, 2019

目前用的都是 En dash(–),只有 subtitle 那里需要改成 Hyphen(-),你可能把两者搞混了

@stevenjoezhang
Copy link
Contributor Author

@Raincal 根据vscode的搜索结果,
(\u8212)出现了四次,在
docs/ru/DATA-FILES.md
docs/ru/README.md
languages/ru.yml
languages/uk.yml
猜测这是西里尔输入法打出的连字符。
(\u8211)出现了四次,在
docs/LICENSE.txt
layout/_partials/footer.swig
layout/index.swig
LICENSE.md
中。这是中文输入法打出的破折号的一半。
因此:

目前用的都是 En dash(–),

不,至少它们的unicode不同

只有 subtitle 那里需要改成 Hyphen(-)

为保持统一性和通用性,应全部替换为-(\u45)

你可能把两者搞混了

可能在交流上出现了一些误解。

@stevenjoezhang
Copy link
Contributor Author

感觉是 #899 的描述有误。维基百科标题用的连字符是\u45。

@1v9
Copy link
Member

1v9 commented Jun 9, 2019

@stevenjoezhang
Copy link
Contributor Author

@1v9 Seems we're talking about the same thing

@stevenjoezhang stevenjoezhang changed the title Use en dash instead of hyphen Use hyphen instead of en dash Jun 9, 2019
@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Jun 9, 2019

I know why. The title is wrong (because the title of #899 is confusing). Everything else is correct.

@Raincal
Copy link
Member

Raincal commented Jun 9, 2019

为保持统一性和通用性,应全部替换为-(\u45)

使用场景不同,应该使用不同的符号,你可以再仔细看下你上面发的链接或者 wiki
https://zh.wikipedia.org/wiki/%E8%BF%9E%E6%8E%A5%E5%8F%B7#En_dash

@1v9
Copy link
Member

1v9 commented Jun 11, 2019

我兹磁都用-,老实说 en dash 我都不会打 😂

@ivan-nginx
Copy link
Member

ivan-nginx commented Jun 11, 2019

Guys, there are 3 types of dash: small (hyphen), middle (for digits) and dash (long). I suggest to use middle dash for best vision for posts. Here we go, see:

image

  1. In literature culture we like to use pretty-good hyphens for string combinations
  2. If we want to calculate, we do it simply: 1+1=2; 1–1=0
  3. Long dashes can be used for author replicas, – Say Ivan right now and drink a cup of tee.

Copy link
Member

@ivan-nginx ivan-nginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Jun 20, 2019

@ivan-nginx

In literature culture we like to use pretty-good hyphens for string combinations

Sites like Wikipedia are using -(\u45), aka small (hyphen), for string combinations
Maybe website is not kind of literature culture 😂

If we want to calculate, we do it simply: 1+1=2; 1–1=0

Emm... not simply. In node or python, 1–1 is not equal to 0 but returns an error message (, \u8211 is invalid token). In fact, when I press the key - on my keyboard, I got a -, not . So, it should be 1+1=2; 1-1=0; not 1–1=0
+ is \u43, and - is \u45. They are simple because ASCII code is simpler than Unicode.

@stevenjoezhang stevenjoezhang merged commit d28b164 into theme-next:master Jun 24, 2019
@stevenjoezhang stevenjoezhang deleted the endash branch June 24, 2019 14:43
@stevenjoezhang
Copy link
Contributor Author

I found this:
#337
#341
interesting 😂

@1v9
Copy link
Member

1v9 commented Jul 7, 2019

@stevenjoezhang Enough, various expressions of this shit symbol... 😂

@1v9
Copy link
Member

1v9 commented Jul 7, 2019

Em Dash

En Dash

Hyphen

@ivan-nginx
Copy link
Member

Just add option for dash, no?

tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The dash that connects the title to the subtitle is not hyphen but en dash
4 participants