Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detailed description about RSS #895

Merged
merged 2 commits into from
Jun 3, 2019
Merged

Add detailed description about RSS #895

merged 2 commits into from
Jun 3, 2019

Conversation

xyyuhans
Copy link
Member

@xyyuhans xyyuhans commented Jun 3, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

I search the keyword "dependencies" to install dependencies in this config file, and I find that I forgot to install rss dependencies because there is no keyword "dependencies" in the description of rss.

What is the new behavior?

So I add the keyword "dependencies" to the description of rss.

Does this PR introduce a breaking change?

  • Yes.
  • No.

xyyuchn added 2 commits June 3, 2019 12:14
I search the keyword "dependencies" to install dependencies in this config file, and I find that I forgot to install rss dependencies because there is no keyword "dependencies" in the description of rss. So I add the keyword "dependencies" to the description of rss.
@welcome
Copy link

welcome bot commented Jun 3, 2019

Thanks so much for opening your first PR here!

@CLAassistant
Copy link

CLAassistant commented Jun 3, 2019

CLA assistant check
All committers have signed the CLA.

@stevenjoezhang stevenjoezhang changed the title add detailed description about rss Add detailed description about RSS Jun 3, 2019
@1v9 1v9 added the 📖 Docs label Jun 3, 2019
@1v9 1v9 added this to the v7.2.0 milestone Jun 3, 2019
@1v9 1v9 merged commit 7829fe9 into theme-next:master Jun 3, 2019
@welcome
Copy link

welcome bot commented Jun 3, 2019

Congrats on merging your first pull request here! 🎉 How awesome!

tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants