Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore the previous selection for copy_button #890

Merged
merged 1 commit into from
Jun 2, 2019
Merged

Restore the previous selection for copy_button #890

merged 1 commit into from
Jun 2, 2019

Conversation

1v9
Copy link
Member

@1v9 1v9 commented Jun 1, 2019 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

If we select something then click the copy button, code is copied but the previous selection will be gone.

What is the new behavior?

The previous selection will be restored.

How to use?

In NexT _config.yml:

codeblock:
  copy_button:
    enable: true

Does this PR introduce a breaking change?

  • Yes.
  • No.

@ivan-nginx
Copy link
Member

What's the point? Screens?

@1v9
Copy link
Member Author

1v9 commented Jun 1, 2019

Oh you too quick, I'm editing it...

@1v9
Copy link
Member Author

1v9 commented Jun 1, 2019 •
edited by unfurl-links bot
Loading

https://caniuse.com/#search=Selection%20API

@1v9 1v9 added the ⭐ Feature label Jun 1, 2019
@1v9 1v9 added this to the v7.2.0 milestone Jun 1, 2019
@1v9 1v9 marked this pull request as ready for review June 1, 2019 13:23
@weekly-digest weekly-digest bot mentioned this pull request Jun 2, 2019
Closed
ivan-nginx
ivan-nginx approved these changes Jun 2, 2019
View reviewed changes
Copy link
Member

@ivan-nginx ivan-nginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Improvement, I think.

@1v9 1v9 merged commit 590c0fb into master Jun 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the copy-code branch June 2, 2019 07:30
@weekly-digest weekly-digest bot mentioned this pull request Jun 9, 2019
Closed
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@1v9
Restore the previous selection for copy_button (theme-next#890)
9ec10c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-nginx ivan-nginx ivan-nginx approved these changes

@maple3142 maple3142 Awaiting requested review from maple3142

@sli1989 sli1989 Awaiting requested review from sli1989

@stevenjoezhang stevenjoezhang Awaiting requested review from stevenjoezhang

Assignees
No one assigned
Labels
🛠 Improvement
Projects
None yet
Milestone
v7.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@1v9 @ivan-nginx