Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge note.styl and note-modern.styl #750

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Merge note.styl and note-modern.styl #750

merged 1 commit into from
Mar 29, 2019

Conversation

1v9
Copy link
Member

@1v9 1v9 commented Mar 29, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Two styls have a lot of duplicate content.

What is the new behavior?

Nothing changed.

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@1v9 1v9 added this to the v7.1.0 milestone Mar 29, 2019
ivan-nginx
ivan-nginx approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@ivan-nginx ivan-nginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, GG WP! 😄

@1v9 1v9 merged commit 7a0b2bb into master Mar 29, 2019
@1v9 1v9 deleted the note-styl branch March 29, 2019 10:37
@liolok liolok changed the title Merged note.styl & note-modern.styl Merge note.styl and note-modern.styl Mar 31, 2019
@weekly-digest weekly-digest bot mentioned this pull request Mar 31, 2019
Closed
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@1v9
Merged note.styl & note-modern.styl (theme-next#750)
6e0b169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-nginx ivan-nginx ivan-nginx approved these changes

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

Assignees
No one assigned
Labels
CSS 🛠 Improvement
Projects
None yet
Milestone
v7.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@1v9 @stevenjoezhang @ivan-nginx