Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DisqusJS comment system #705

Merged
merged 3 commits into from
Mar 17, 2019
Merged

DisqusJS comment system #705

merged 3 commits into from
Mar 17, 2019

Conversation

1v9
Copy link
Member

@1v9 1v9 commented Mar 17, 2019 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: #586

What is the new behavior?

1.gif

How to use?

In NexT _config.yml:

# DisqusJS
# Demo: https://suka.js.org/DisqusJS/
disqusjs:
  enable: true
  # API Endpoint of Disqus API (https://disqus.com/api/)
  # leave api empty if you are able to connect to Disqus API
  # otherwise you need a reverse proxy for Disqus API
  # For example: 
  # api: https://disqus.skk.moe/disqus/
  api:
  apikey: <apikey> # register new application from https://disqus.com/api/applications/
  shortname: <shortname> # See: https://disqus.com/admin/settings/general/

Does this PR introduce a breaking change?

  • Yes.
  • No.

@1v9
Feat: Add DisqusJS support
f0e7591 
* #586

* share div with disqus
@1v9 1v9 requested review from stevenjoezhang, ivan-nginx and maple3142 and removed request for stevenjoezhang and ivan-nginx March 17, 2019 16:47
@stevenjoezhang
Copy link
Contributor

How about moving the options here? Right after disqus?

屏幕快照 2019-03-18 上午12 49 56

@1v9 1v9 merged commit 72d5903 into theme-next:master Mar 17, 2019
@ivan-nginx ivan-nginx mentioned this pull request Mar 17, 2019
Closed
72 tasks
@1v9 1v9 deleted the DisqusJS branch March 17, 2019 18:37
@stevenjoezhang stevenjoezhang added this to the v7.1.0 milestone Mar 18, 2019
@1v9 1v9 changed the title Feat: Add DisqusJS support Added DisqusJS support Mar 19, 2019
@liolok liolok changed the title Added DisqusJS support Add DisqusJS support Mar 31, 2019
@liolok liolok changed the title Add DisqusJS support DisqusJS Mar 31, 2019
@liolok liolok changed the title DisqusJS DisqusJS comment system Mar 31, 2019
@stevenjoezhang stevenjoezhang mentioned this pull request Jun 1, 2019
Merged
15 tasks
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@1v9
Feat: Add DisqusJS support (theme-next#705)
2879573 
* Feat: Add DisqusJS support

* theme-next#586

* share div with disqus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

@maple3142 maple3142 Awaiting requested review from maple3142

@ivan-nginx ivan-nginx Awaiting requested review from ivan-nginx

Assignees
No one assigned
Labels
🌟 New Feature 🎯 Roadmap
Projects
None yet
Milestone
v7.1.0
Development

Successfully merging this pull request may close these issues.

Add disqusJS comment system
2 participants
@1v9 @stevenjoezhang