-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Tabs flexible #704
Make Tabs flexible #704
Conversation
Besides, the overflow issue(#691) also happens on desktop platform. This bug fix is not only for mobile platform |
This comment has been minimized.
This comment has been minimized.
Emm ...maybe it looks a little strange... |
Ok, no need to fix tabs. I'll fix it bmyself. Because there are really hard and bug hard too. |
@ivan-nginx I have updated the code, you can check again |
No changes. Tabs still jumping.
|
This is a flat design, not intended to be materialized. This is consistent with the design of NexT
Cannot be implemented by CSS and flex alone |
@ivan-nginx What's your opinion? If you would like to fix the bug yourself, I'll close this PR. Hope this provides some ideas. |
Stay it open. Just give me access to your repo to let me possibility push changes into this PR directly. |
No problem, I will handle the repo's write permissions. |
@ivan-nginx And your fifth point:
It looks terrible if you have three cols of tabs with different width |
I have updated some code, tabs will no longer shaking now |
@ivan-nginx @stevenjoezhang new style, just tried it |
* Update tabs.styl
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue resolved: #691
What is the new behavior?
Classical Win XP Design
How to use?
In NexT
_config.yml
:Does this PR introduce a breaking change?
Source code