Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic unlimited reward additions and animation option #695

Merged
merged 3 commits into from
Mar 16, 2019
Merged

Dynamic unlimited reward additions and animation option #695

merged 3 commits into from
Mar 16, 2019

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Mar 16, 2019

Changes in _config.yml:

-reward:
-  enable: false
-  animation: false
-  #comment: Donate comment here
-  #wechatpay: /images/wechatpay.jpg	
-  #alipay: /images/alipay.jpg	reward:
-  #bitcoin: /images/bitcoin.jpg
+reward_settings:
+  enable: false
+  animation: false
+  #comment: Donate comment here
+reward:
+  #wechatpay: /images/wechatpay.png
+  #alipay: /images/alipay.png
+  #bitcoin: /images/bitcoin.png

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: #596, iissnan/hexo-theme-next#2199

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

+reward_settings:
+  enable: true
+  animation: false
+  comment: Donate comment here

In NexT _config.yml:

reward:
  wechatpay: /images/wechatpay.png
  alipay: /images/alipay.png
  bitcoin: /images/bitcoin.png
  paypal: /images/paypal.png
  monero: /images/monero.png
  ...

Does this PR introduce a breaking change?

  • Yes.
  • No.

reward:
#wechatpay: /images/wechatpay.png
#alipay: /images/alipay.png
#bitcoin: /images/bitcoin.png

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#monero: /images/monero.png

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add monero and paypal as examples to the docs

@ivan-nginx ivan-nginx added this to the v7.1.0 milestone Mar 16, 2019
@stevenjoezhang stevenjoezhang merged commit 39bc009 into theme-next:master Mar 16, 2019
@stevenjoezhang stevenjoezhang deleted the reward branch March 16, 2019 08:31
@ivan-nginx ivan-nginx changed the title Refactoring post reward Allowed dynamic unlimited reward additions & Added animation option Mar 16, 2019
@ivan-nginx ivan-nginx changed the title Allowed dynamic unlimited reward additions & Added animation option Allowed dynamic unlimited reward additions & Added animation option Mar 16, 2019
@liolok liolok changed the title Allowed dynamic unlimited reward additions & Added animation option Allow dynamic unlimited reward additions & add animation option Mar 31, 2019
@liolok liolok changed the title Allow dynamic unlimited reward additions & add animation option Dynamic unlimited reward additions and animation option Mar 31, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
* Add `reward_settings` option

* Allow dynamic unlimited additions
rjyblog pushed a commit to rjyblog/hexo-theme-next that referenced this pull request Oct 17, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It is recommended to add unionpay support in reward. / 建议添加云闪付收款码至Reward列表
2 participants