reward button vertical align text

[1v9]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines.
• Tests for the changes was maked (for bug fixes / features).
  • Muse | Mist have been tested.
  • Pisces | Gemini have been tested.
• Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

• Bugfix.
• Feature.
• Code style update (formatting, local variables).
• Refactoring (no functional changes, no api changes).
• Build related changes.
• CI related changes.
• Documentation content changes.
• Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

• Yes.
• No.

[stevenjoezhang]

Will be fixed in #689.

No need to add a hardcoded line height, I think

[1v9]

@stevenjoezhang 😂 I found this because I tried to add option for animation of reward.

[1v9]

is ok to remove W&H?

[stevenjoezhang]

You can merge it, and I'll update #689 then
Also see this: iissnan/hexo-theme-next#1856

[1v9]

@stevenjoezhang yes I saw that in roadmap, this is new style

[1v9]

New style is nice I think, how we solve this?

[ivan-nginx]

Will be fixed in #689.

No need to add a hardcoded line height, I think

You can merge it, and I'll update #689 then
Also see this: iissnan/hexo-theme-next#1856

See what I'm talking about mixed before? About mixed Features & Fixes & Optimizations. This approach more troubles than we think. 🌗

[ivan-nginx]

@stevenjoezhang yes I saw that in roadmap, this is new style

Maybe a little bigger? + 3-5px. It's a little bit hard to click on donate...

---

And live demo, if u can.

[stevenjoezhang]

@ivan-nginx Emm.. I hardly agree it's "mixed". When I implement a new feature, I found something is broken by it (reward button looks strange when font-size is larger than 20px), so I fixed it. Just like this animation shows:

Adding a new feature is not just adding a feature 🌗 Have to handle the bugs caused by this feature

[1v9]

@ivan-nginx @stevenjoezhang For me, both styles are acceptable, but it's indeed a bit crowded if #689 merged. Maybe keep it like before?

[stevenjoezhang]

@1v9 Maybe you can fix this: iissnan/hexo-theme-next#687 (comment)
Add an option?

[1v9]

@stevenjoezhang you mean roll animation? It's done but I'm finding is there a better code, you know I'm not an expert.

[stevenjoezhang]

@1v9 Don't worry, take your time. There is a lot of feature requests about reward button, like this: iissnan/hexo-theme-next#687 (comment) 😂

[ivan-nginx]

Add an option?

Yes, add an option and by default don't shake label under the cursor.

[stevenjoezhang]

And this issue: #596. Maybe we need to refactor this function.

[ivan-nginx]

Dynamic unlimited additions?

[stevenjoezhang]

@ivan-nginx Yes. And this one: https://github.com/iissnan/hexo-theme-next/pull/2199/files

[ivan-nginx]

@stevenjoezhang I mean: they repeat same code with just different names. I want to create something like enumeration of arrays to provide any unlimited pictures and names with donations. For example, see menu & submenu(s) implementation with icons to them.

[stevenjoezhang]

@ivan-nginx Yes, I understand what you mean.