Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colored link for modern notes with exturl #685

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Colored link for modern notes with exturl #685

merged 1 commit into from
Mar 14, 2019

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Mar 14, 2019 •
edited by ivan-nginx
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: #578

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@stevenjoezhang stevenjoezhang changed the title Fix #578: Fix #578: Link color in modern notes with exturl Mar 14, 2019
ivan-nginx
ivan-nginx approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@ivan-nginx ivan-nginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@stevenjoezhang stevenjoezhang merged commit dcf789d into theme-next:master Mar 14, 2019
@stevenjoezhang stevenjoezhang deleted the note branch March 14, 2019 03:41
mxdh added a commit to mxdh/hexo-theme-next that referenced this pull request Mar 14, 2019
@mxdh
Merge pull request #1 from theme-next/master
c497cee 
Make the color of exturl link in notes the same as other text (theme-next#685)
@ivan-nginx ivan-nginx changed the title Fix #578: Link color in modern notes with exturl Colored link for modern notes with exturl Mar 17, 2019
@stevenjoezhang stevenjoezhang added this to the v7.1.0 milestone Mar 18, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@stevenjoezhang
Make the color of exturl link in notes the same as other text (theme-…
fabf012 
…next#685)
rjyblog pushed a commit to rjyblog/hexo-theme-next that referenced this pull request Oct 17, 2023
@renovate
Update dependency eslint to v8.48.0 (theme-next#685)
fe8a01f 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-nginx ivan-nginx ivan-nginx approved these changes

Assignees
No one assigned
Labels
🐞 Bug Fix CSS
Projects
None yet
Milestone
v7.1.0
Development

Successfully merging this pull request may close these issues.

Link color in modern notes with exturl must be same as background color
2 participants
@stevenjoezhang @ivan-nginx