Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text_align option. #682

Merged
merged 4 commits into from
Mar 16, 2019
Merged

Add text_align option. #682

merged 4 commits into from
Mar 16, 2019

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Mar 13, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: #73, Roadmap

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@1v9
Copy link
Member

1v9 commented Mar 13, 2019

We need a expert CSS worker 😉

@1v9 1v9 requested review from jiangtj and sli1989 March 13, 2019 12:51
@stevenjoezhang stevenjoezhang requested review from ivan-nginx, jiangtj and sli1989 and removed request for sli1989 and jiangtj March 14, 2019 06:08
@sli1989
Copy link
Collaborator

sli1989 commented Mar 15, 2019

Nothing know about css, but 👍

Copy link
Member

@ivan-nginx ivan-nginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good, but how about add global align option, not only for mobile devices?

@ivan-nginx ivan-nginx changed the title Add mobile_text_justify option Added mobile_text_justify option. Mar 15, 2019
@ivan-nginx ivan-nginx added this to the v7.1.0 milestone Mar 15, 2019
@ivan-nginx ivan-nginx mentioned this pull request Mar 15, 2019
72 tasks
@stevenjoezhang
Copy link
Contributor Author

@ivan-nginx How do you like options like this:

text-align:
  # Available values: start | end | left | right | center | justify | justify-all | match-parent
  desktop: justify
  mobile: justify

@ivan-nginx
Copy link
Member

Yep. Seems good.

@stevenjoezhang
Copy link
Contributor Author

Updated. I'll add the docs

@stevenjoezhang stevenjoezhang changed the title Added mobile_text_justify option. Added text_align option. Mar 16, 2019
@stevenjoezhang stevenjoezhang merged commit 312f5b6 into theme-next:master Mar 16, 2019
@stevenjoezhang stevenjoezhang deleted the doc branch March 16, 2019 02:16
@ivan-nginx
Copy link
Member

ivan-nginx commented Mar 16, 2019

Maybe not justify by default? What is default value for text-align?


Default value is left. But I suggest to set start value. See here.

@stevenjoezhang
Copy link
Contributor Author

@ivan-nginx No need to concern about it, the default value doesn't change in this PR:
屏幕快照 2019-03-16 上午10 40 45
屏幕快照 2019-03-16 上午10 41 02

@ivan-nginx
Copy link
Member

I know what there is no breaking change. I just suggest to think about justify by default and as for me, I always prefer turn off justify as on Desktop and for Mobiles too. I'm talking about en and ru languages, IDK how will better for cn.

@stevenjoezhang
Copy link
Contributor Author

I'll add a notice in the docs, about the difference between those options.

@liolok liolok changed the title Added text_align option. Add text_align option. Mar 31, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants