Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For long mathjax equations with short viewport horizontal scrollbar will appear #669

Merged
merged 1 commit into from
Mar 12, 2019

Conversation

zq1997
Copy link
Contributor

@zq1997 zq1997 commented Mar 9, 2019

The detail is discussed under issue #645 , maybe this PR can make some help. Please refer to the last two paragraph of my blog(only in Chinese) for its change explanation.

also prevent unexpected scroll bar(issue #658)
@stevenjoezhang
Copy link
Contributor

Good job!

Copy link
Contributor

@stevenjoezhang stevenjoezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it on multiple browsers on macOS and iOS, they all worked fine. Need to wait for others to confirm

@1v9 1v9 self-requested a review March 10, 2019 07:08
@stevenjoezhang stevenjoezhang added this to the v7.1.0 milestone Mar 10, 2019
@1v9
Copy link
Member

1v9 commented Mar 11, 2019

Merge?

@stevenjoezhang
Copy link
Contributor

Wait...

overflow-y: hidden;
}

li {
list-style-position: inside !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zq-97 Is this related to Mathjax? All <li> elements in the page are affected

Copy link
Contributor Author

@zq1997 zq1997 Mar 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a bug of many browser(chrome, safari, firefox ...), See here.

In short, if you put something with 'overflow' css inside a li element, the leading symbol (dot/circle for unordered or number for ordered) WILL DISAPPERA.

You can have a simple try w/o list-style-position: inside !important; using the flowing content.

- $\alpha$
- $\beta$

Because it is a bug of browser, I didn't found any better solution. You can remove this style if necessary.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could cause a problem that the start indent of any list looks too long. Please check the behavior of usual list before and after setting "list-style-position: inside".

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue I just closed actually is also caused by it:
#721

@stevenjoezhang stevenjoezhang merged commit 22a156f into theme-next:master Mar 12, 2019
@ivan-nginx ivan-nginx changed the title Fix for issue #645 (and also #658) For long mathjax equations with short viewport horizontal scrollbar will appear Mar 16, 2019
@Raincal
Copy link
Member

Raincal commented Mar 16, 2019

@all-contributors please add @zq-97 for bug and code

@allcontributors
Copy link
Contributor

@Raincal

I've put up a pull request to add @zq-97! 🎉

@ivan-nginx
Copy link
Member

Wow! 👍

rjyblog pushed a commit to rjyblog/hexo-theme-next that referenced this pull request Oct 17, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants