-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For long mathjax equations with short viewport horizontal scrollbar will appear #669
Conversation
also prevent unexpected scroll bar(issue #658)
Good job! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it on multiple browsers on macOS and iOS, they all worked fine. Need to wait for others to confirm
Merge? |
Wait... |
overflow-y: hidden; | ||
} | ||
|
||
li { | ||
list-style-position: inside !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zq-97 Is this related to Mathjax? All <li>
elements in the page are affected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a bug of many browser(chrome, safari, firefox ...), See here.
In short, if you put something with 'overflow' css inside a li
element, the leading symbol (dot/circle for unordered or number for ordered) WILL DISAPPERA.
You can have a simple try w/o list-style-position: inside !important;
using the flowing content.
- $\alpha$
- $\beta$
Because it is a bug of browser, I didn't found any better solution. You can remove this style if necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could cause a problem that the start indent of any list looks too long. Please check the behavior of usual list before and after setting "list-style-position: inside".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue I just closed actually is also caused by it:
#721
@all-contributors please add @zq-97 for bug and code |
I've put up a pull request to add @zq-97! 🎉 |
Wow! 👍 |
also prevent unexpected scroll bar (theme-next#658)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
The detail is discussed under issue #645 , maybe this PR can make some help. Please refer to the last two paragraph of my blog(only in Chinese) for its change explanation.