Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lost tracking_id in google_analytics #668

Merged
merged 1 commit into from
Mar 9, 2019
Merged

Lost tracking_id in google_analytics #668

merged 1 commit into from
Mar 9, 2019

Conversation

sheiun
Copy link
Contributor

@sheiun sheiun commented Mar 9, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

google tag will load like this //www.googletagmanager.com/gtag/js?id=[object%20Object]
Issue resolved: N/A

What is the new behavior?

//www.googletagmanager.com/gtag/js?id=UA-XXXXXXX-XXX

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

Change google-analytics.swig from

<script async src="//www.googletagmanager.com/gtag/js?id={{ theme.google_analytics }}"></script>

to

<script async src="//www.googletagmanager.com/gtag/js?id={{ theme.google_analytics.tracking_id }}"></script>

Does this PR introduce a breaking change?

  • Yes.
  • No.

Fix lost tracking_id in google_analytics
@stevenjoezhang stevenjoezhang added this to the v7.1.0 milestone Mar 9, 2019
@stevenjoezhang
Copy link
Contributor

Good job!

@stevenjoezhang stevenjoezhang merged commit 31714e5 into theme-next:master Mar 9, 2019
@ivan-nginx ivan-nginx changed the title Fix lost tracking_id in google_analytics Fixed lost tracking_id in google_analytics Mar 16, 2019
@liolok liolok changed the title Fixed lost tracking_id in google_analytics Lost tracking_id in google_analytics Mar 31, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
rjyblog pushed a commit to rjyblog/hexo-theme-next that referenced this pull request Oct 17, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants