Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add language option to creative_commons #628

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Feat: Add language option to creative_commons #628

merged 1 commit into from
Feb 26, 2019

Conversation

1v9
Copy link
Member

@1v9 1v9 commented Feb 25, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

By default, the link of CC license is like this: https://creativecommons.org/licenses/by-nc-nd/4.0/

What is the new behavior?

If add deed.zh to language option in creative_commons the the link will be https://creativecommons.org/licenses/by-nc-nd/4.0/deed.zh

How to use?

In NexT _config.yml:

  • Add a value to language
creative_commons:
  license: by-nc-sa
  sidebar: true
  post: true
  language: deed.fr
  • Or leave it empty, nothing happend.
creative_commons:
  license: by-nc-sa
  sidebar: true
  post: true
  language:

Does this PR introduce a breaking change?

  • Yes.
  • No.

* Update _config.yml

* Update sidebar.swig

* Update post-copyright.swig
@ivan-nginx ivan-nginx merged commit 122cb12 into theme-next:master Feb 26, 2019
@ivan-nginx ivan-nginx added this to the v7.1.0 milestone Feb 26, 2019
@1v9 1v9 deleted the CC branch February 27, 2019 12:00
@ivan-nginx
Copy link
Member

Also, can u add docs in NexT website how to use this feature?

@1v9
Copy link
Member Author

1v9 commented Mar 4, 2019

Also, can u add docs in NexT website how to use this feature?

I will.

1v9 added a commit to theme-next/theme-next.org that referenced this pull request Mar 4, 2019
ivan-nginx pushed a commit to theme-next/theme-next.org that referenced this pull request Mar 4, 2019
@yongqilei
Copy link

I want to know whether it has Chinese language or not? I want to set my website's language to Chinese.

@ivan-nginx
Copy link
Member

@rayyq https://creativecommons.org/licenses/by-nc-nd/4.0/deed.zh

@yongqilei
Copy link

@rayyq https://creativecommons.org/licenses/by-nc-nd/4.0/deed.zh

@ivan-nginx Thank u , so I just need to set the config language with 'deed.zh', right? :)

@ivan-nginx
Copy link
Member

Follow to documentation in changed files → Valid values of language: deed.zh, deed.fr, deed.de , etc.

tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
* Update _config.yml

* Update sidebar.swig

* Update post-copyright.swig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants