Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #601 Ordered list nested in unordered list became unordered #602

Merged
merged 1 commit into from
Feb 10, 2019
Merged

Fix #601 Ordered list nested in unordered list became unordered #602

merged 1 commit into from
Feb 10, 2019

Conversation

stevenjoezhang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved #601

What is the new behavior?

Description about this pull, in several words...

  • Screens with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@stevenjoezhang stevenjoezhang added this to the v7.1.0 milestone Feb 7, 2019
jiangtj
jiangtj approved these changes Feb 10, 2019
View reviewed changes
Copy link
Member

@jiangtj jiangtj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested! Good job!
https://jiangtj.gitlab.io/next-test/muse/2019/02/10/list/
https://jiangtj.gitlab.io/next-test/muse/2019/02/10/fancybox/
But why force-push?
default

@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Feb 10, 2019 •
edited
Loading

Just to make working tree clear... squash and merge has the same effect

@stevenjoezhang stevenjoezhang merged commit 7d7078c into theme-next:master Feb 10, 2019
@stevenjoezhang stevenjoezhang mentioned this pull request Mar 8, 2019
Closed
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@stevenjoezhang
Fix theme-next#601: Ordered list nested in unordered list became unor…
8d54472 
…dered (theme-next#602)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-nginx ivan-nginx ivan-nginx left review comments

@jiangtj jiangtj jiangtj approved these changes

@maple3142 maple3142 Awaiting requested review from maple3142

@sli1989 sli1989 Awaiting requested review from sli1989

Assignees
No one assigned
Labels
🐞 Bug Fix
Projects
None yet
Milestone
v7.0.1
Development

Successfully merging this pull request may close these issues.

Ordered list nested in unordered list became unordered
3 participants
@stevenjoezhang @jiangtj @ivan-nginx